Repository navigation
[Awaiting Payment 26th August] [$250] [Payment card / Subscription] Make change billing card currency form wait until request has finished before closing #45645
Description
Problem
When changing the billing currency on the subscription page, the panel closes immediately after clicking "save". This is a problem because if the request has an error we should show that error in the panel, but the panel will have already closed.
Screen.Recording.2024-07-29.at.4.54.04.PM.mov
Solution
We should have this panel behave the same way that the add payment card panel behaves. It should wait for the request to finish and show a loading indicator while we wait.
cc: @dominictb
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01bcbde08595f89c2b
- Upwork Job ID: 1818075810728864794
- Last Price Increase: 2024-07-30
- Automatic offers:
- nkdengineer | Contributor | 103346635
Activity
blimpich commentedon Jul 17, 2024
Holding and not adding the external label until necessary backend changes are done
melvin-bot commentedon Jul 23, 2024
@blimpich Huh... This is 4 days overdue. Who can take care of this?
blimpich commentedon Jul 23, 2024
Almost there, backend changes are still in review.
melvin-bot commentedon Jul 29, 2024
@blimpich Huh... This is 4 days overdue. Who can take care of this?
[-][Payment card / Subscription][HOLD #45124] Make change billing card currency form wait until request has finished before closing[/-][+][Payment card / Subscription] Make change billing card currency form wait until request has finished before closing[/+]32 remaining items
garrettmknight commentedon Aug 20, 2024
@isabelastisser looks like the PR is on prod btw.
isabelastisser commentedon Aug 20, 2024
Thanks for the heads up, @garrettmknight! So we're waiting for the PR to merge.
trjExpensify commentedon Aug 26, 2024
PR hit prod on the 19th August. #46635
[-][$250] [Payment card / Subscription] Make change billing card currency form wait until request has finished before closing[/-][+][Awaiting Payment 26th August] [$250] [Payment card / Subscription] Make change billing card currency form wait until request has finished before closing[/+]isabelastisser commentedon Aug 27, 2024
Payment summary:
@rushatgabhane $250 / C+ review / NewDot payment
PENDING@nkdengineer $250 / Contributor / Paid in Upwork
JmillsExpensify commentedon Aug 27, 2024
$250 approved for @rushatgabhane