Skip to content

[HOLD for payment 2024-08-26] [Upgrades] [$250] Workspace - Incorrect app navigation after clicking on back button on upgrade RHP #45682

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to More features.
  3. Scroll down.
  4. Toggle on Report fields.
  5. Click on the back button on RHP.
  6. Note that the page scrolls up.
  7. Enable Accounting.
  8. Go to Accounting.
  9. Toggle on NetSuite.
  10. Click on the back button on RHP.
  11. Note that app returns to workspace profile page.

Expected Result:

In Step 6, page will not scroll up after clicking on back button on RHP
In Step 11, app will remain on the same accounting page after clicking on back button on RHP

Actual Result:

In Step 6, page scrolls up after clicking on back button on RHP
In Step 11, app remains on the same accounting page after clicking on back button on RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop #45930

Screenshots/Videos

Add any screenshot/video evidence

Bug6546241_1721312718504.20240718_222222.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015d4828d1746446dd
  • Upwork Job ID: 1813956464241732548
  • Last Price Increase: 2024-07-18
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 18, 2024
  2. melvin-bot commented on Jul 18, 2024

    @melvin-bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 18, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 18, 2024
  5. changed the title [-]Workspace - Incorrect app navigation after clicking on back button on upgrade RHP[/-] [+][$250] Workspace - Incorrect app navigation after clicking on back button on upgrade RHP[/+] on Jul 18, 2024
  6. melvin-bot commented on Jul 18, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 18, 2024
  8. melvin-bot commented on Jul 18, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  9. roryabraham commented on Jul 18, 2024

    @roryabraham
    Contributor

    not 100% sure this needs to block deploy. It's definitely not a back-end issue though

  10. 47 remaining items

  11. melvin-bot commented on Aug 14, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. melvin-bot commented on Aug 15, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. garrettmknight commented on Aug 28, 2024

    @garrettmknight
    Contributor

    Going to keep this one open to confirm payment with @rushatgabhane for his review. Slack convo here.

  14. changed the title [-][Upgrades] [$250] Workspace - Incorrect app navigation after clicking on back button on upgrade RHP[/-] [+][HOLD for payment 2024-08-26] [Upgrades] [$250] Workspace - Incorrect app navigation after clicking on back button on upgrade RHP[/+] on Aug 28, 2024
  15. garrettmknight commented on Sep 2, 2024

    @garrettmknight
    Contributor

    Closing - still waiting on @rushatgabhane to request payment though.

  16. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Sep 2, 2024
  17. JmillsExpensify commented on Sep 2, 2024

    @JmillsExpensify
    Contributor

    Payment summary:

  18. garrettmknight commented on Sep 2, 2024

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions