Repository navigation
[HOLD for payment 2024-08-07] Free trial badge displayed in LHN #45700
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721304565430729
Action Performed:
- Create a new account and select Track and Budget Expenses onboarding task.
- This will result in a task for Track an expense.
- Create a new workspace.
Expected Result:
The task report in LHN should not show Free trial badge. The parent Concierge or Expensify chat should show the badge.
Actual Result:
Free trial badge displayed in LHN. when the onboarding chat is Concierge , the tasks created within the Concierge report (e.g. Track an Expense ) will also displays the Free trial badge.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jul 18, 2024
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.rojiphil commentedon Jul 18, 2024
@twisterdotcom I will raise a PR for this as mentioned in slack conversation here
allgandalf commentedon Jul 18, 2024
does this need a C+ review @rojiphil ? I was assigned to the PR
rojiphil commentedon Jul 18, 2024
Well! Not sure since this is an easy fix. @mountiny Can you please weigh in here?Oh! Looking at this freshly on a new day, I think @fabioh8010 can review this based on the slack convo here
allgandalf commentedon Jul 19, 2024
yeah alright, just ping me in case you need a review at all
rojiphil commentedon Aug 4, 2024
@twisterdotcom Can we please process the payment here since the fix has been in production since 23 July as mentioned here
[-]Free trial badge displayed in LHN[/-][+][HOLD for payment 2024-08-07] Free trial badge displayed in LHN[/+]twisterdotcom commentedon Aug 6, 2024
Just adding labels and a date to remind me to get to this tomorrow morning.
twisterdotcom commentedon Aug 7, 2024
Payment Summary: