[HOLD for payment 2024-08-02] [Payment card / Subscription] - Subcriptions leads to not here page after Control workspace is deleted

@adelekennedy

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Create a new account (to have an account with no trial)
Create a workspace
Go to More features
Toggle on Report fields
Click Upgrade to upgrade to Control
Go back to Account settings
Click Subscriptions
Note that the page opens without issue
Now delete the Control workspace
Go back to Account settings
Click Subscriptions

Expected Result:

Subcriptions tab should disappear if it is not available when there is no Control workspace

Actual Result:

Subcriptions leads to not here page after the Control workspace is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6546397_1721320613164.20240719_002948.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

@OfstadC

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@OfstadC

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Subcriptions leads to not here page after Control workspace is deleted

What is the root cause of that problem?

We are checking if there is privateSubscription here before adding subscription menu item to workspaceMenuItemsData. When a workspace is deleted, privateSubscription have autoRenewLastChangedDate , pendingFields and type properties. Therefore it is considered to be a truthy value and subscription item will be added to workspaceMenuItemsData.

App/src/pages/settings/InitialSettingsPage.tsx

Lines 206 to 208 in 8e9c681

    
           if (privateSubscription) { 
        
               items.splice(1, 0, { 
        
                   translationKey: 'allSettingsScreen.subscription',

What changes do you think we should make in order to solve the problem?

We should use useSubscriptionPlan(); to check if the user has active subscription (collect or control subscription)

const subscriptionPlan = useSubscriptionPlan();

Don't add subscription item to workspaceMenuItemsData if subscriptionPlan === null

  if (subscriptionPlan) {
            items.splice(1, 0, {
                translationKey: 'allSettingsScreen.subscription',

Note: we will add subscriptionPlan to the useMemo dependency.

What alternative solutions did you explore? (Optional)

N/A

@OfstadC

@OfstadC Whoops! This issue is 2 days overdue. Let's get this updated quick!

Looking at this now

I don't have the option for Report Fields 🤔 so I can't reproduce.

I don't have the option for Report Fields 🤔 so I can't reproduce.

You have to use expensifail account. The feature is under beta. That is why you are not seeing the feature.

I don't get the same result

@OfstadC

@OfstadC Still reproducible by the tester

bandicam.2024-07-24.00-20-06-037.mp4

@kavimuru

Thanks @kavimuru !

@adelekennedy

@adelekennedy We're waiting on @rojiphil to complete BZ checklist - and then we need to issue payment on 8/2. I'll be fully offline on Friday so looping you in so we can pay this on time. Thank youuuu ❤️

@rojiphil

Payment Summary

Upwork Job

ROLE: @rojiphil paid $250 via Upwork
Contributor: @narefyev91 is from an agency-contributor and not due payment

BugZero Checklist (@adelekennedy)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@rojiphil

Sent @rojiphil offer via Upwork

@rojiphil

[@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
[@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
[@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.
[@rojiphil] Determine if we should create a regression test for this bug. : Since the changes are related to display/hide of subscription menu in LHN which is common usage, we can add a regression test.
[@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Test Steps
1 Create a new account (to have an account with no trial)
2 Create a workspace
3 Go to More features
4 Toggle on Report fields
5 Click Upgrade to upgrade to Control
6 Go back to Account settings
7 Click Subscriptions
8 Change subscription to "Pay-per-use"
9 Note that the page opens without issue
10 Now delete the Control workspace
11 Go back to Account settings
12 Verify that subscription is not shown anymore

@adelekennedy

@adelekennedy @OfstadC Completed BZ Checklist and accepted offer too. Thanks.

@rojiphil

Payment made @rojiphil!

https://github.com/Expensify/Expensify/issues/418028

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-02] [Payment card / Subscription] - Subcriptions leads to not here page after Control workspace is deleted #45720

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

27 remaining items

Payment Summary

BugZero Checklist (@adelekennedy)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (privateSubscription) {
	items.splice(1, 0, {
	translationKey: 'allSettingsScreen.subscription',

[HOLD for payment 2024-08-02] [Payment card / Subscription] - Subcriptions leads to not here page after Control workspace is deleted #45720

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 18, 2024

lanitochka17 commented on Jul 18, 2024

etCoderDysto commented on Jul 18, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 22, 2024

OfstadC commented on Jul 22, 2024

OfstadC commented on Jul 22, 2024

etCoderDysto commented on Jul 22, 2024

OfstadC commented on Jul 23, 2024

kavimuru commented on Jul 23, 2024

OfstadC commented on Jul 23, 2024

27 remaining items

OfstadC commented on Jul 31, 2024

melvin-bot commented on Aug 2, 2024

Payment Summary

BugZero Checklist (@adelekennedy)

adelekennedy commented on Aug 2, 2024

rojiphil commented on Aug 3, 2024

rojiphil commented on Aug 3, 2024

adelekennedy commented on Aug 5, 2024

adelekennedy commented on Aug 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions