[HOLD for payment 2024-08-01] [$125] [HIGH] [API Reliability] Opening the Wallet page calls the OpenPaymentsPage twice

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721384323190839

Action Performed:

Break down in numbered steps

Open Console > Networks tab
Open Profile
Open the Wallet page

Expected Result:

Describe what you think should've happened

The OpenPaymentsPage read call is made only once

Actual Result:

Describe what actually happened

The API was called twice

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015c4debdbfd2eca47
Upwork Job ID: 1814254841623728799
Last Price Increase: 2024-07-19
Automatic offers:

nyomanjyotisa | Contributor | 103183901

Issue Owner

Current Issue Owner: @mallenexpensify

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening the Wallet page calls the OpenPaymentsPage twice

What is the root cause of that problem?

The root cause of this problem is the presence of two separate useEffect hooks in WalletPage.tsx that both trigger the PaymentMethods.openWalletPage() function, leading to the API being called twice during the page load process.

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 276 to 278 in c1881ed

    
           useEffect(() => { 
        
               PaymentMethods.openWalletPage(); 
        
           }, []);

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 289 to 294 in c1881ed

    
           useEffect(() => { 
        
               if (network.isOffline) { 
        
                   return; 
        
               } 
        
               PaymentMethods.openWalletPage(); 
        
           }, [network.isOffline]);

What changes do you think we should make in order to solve the problem?

We can remove this one an only trigger the openWalletPage here

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~015c4debdbfd2eca47

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@nyomanjyotisa

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

remove duplicate api calls on wallet page load #45759

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

@nyomanjyotisa requires payment automatic offer (Contributor)
@thesahindia requires payment through NewDot Manual Requests

@thesahindia

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@nyomanjyotisa

Contributor: @nyomanjyotisa paid $125 via Upwork
Contributor+: @thesahindia owed $125 via NewDot

@thesahindia plz complete the BZ checklist above.

@thesahindia

[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:

#22412

[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/22412/files#r1701365475

[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not needed

[@thesahindia] Determine if we should create a regression test for this bug.

Not needed

@mallenexpensify

@mallenexpensify, @mountiny, @nyomanjyotisa, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

@thesahindia

@thesahindia if you propose we don't want a regression test case, can you provide reasoning why you think we don't need one? For this, I'm assuming it's because The OpenPaymentsPage read call is made only once is more of a backend thing that just needed to be updated and checking for that each time isn't necessary.

@thesahindia

@thesahindia if you propose we don't want a regression test case, can you provide reasoning why you think we don't need one? For this, I'm assuming it's because The OpenPaymentsPage read call is made only once is more of a backend thing that just needed to be updated and checking for that each time isn't necessary.

It was a very specific issue. We added the same code twice and because of that we were calling the api twice.

@thesahindia

$125 approved for @thesahindia

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-01] [$125] [HIGH] [API Reliability] Opening the Wallet page calls the OpenPaymentsPage twice #45754

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	if (network.isOffline) {
	return;
	}
	PaymentMethods.openWalletPage();
	}, [network.isOffline]);

[HOLD for payment 2024-08-01] [$125] [HIGH] [API Reliability] Opening the Wallet page calls the OpenPaymentsPage twice #45754

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 19, 2024

nyomanjyotisa commented on Jul 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jul 19, 2024

melvin-bot commented on Jul 19, 2024

16 remaining items

melvin-bot commented on Jul 25, 2024

melvin-bot commented on Jul 25, 2024

melvin-bot commented on Jul 25, 2024

mallenexpensify commented on Aug 1, 2024

thesahindia commented on Aug 2, 2024

melvin-bot commented on Aug 6, 2024

mallenexpensify commented on Aug 7, 2024

thesahindia commented on Aug 8, 2024

JmillsExpensify commented on Aug 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions