Repository navigation
[HOLD for payment 2024-08-01] Thread - Error shows up when user sends a message after leaving the thread #45822
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to any chat
- Send a message
- Right click on the message > Reply in thread
- Send a reply in thread
- Click on the chat header
- Click Leave
- Send a message
Expected Result:
User will be able to send a message
Actual Result:
Error "You don't have access to this chat room." shows up when user sends a message after leaving the thread.
You don't have access to this chat room.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
github-actions commentedon Jul 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @roryabraham (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Jul 20, 2024
We think that this bug might be related to #vip-vsp
mountiny commentedon Jul 22, 2024
In production you are not able to leave the thread from the RHP
mountiny commentedon Jul 22, 2024
cc @bernhardoj I think this is coming from your PR #45136 @akinwale
I believe user has to be navigated to the parent chat when they leave a thread, so that they have to join it again by OpenReport when they want to post new messages
mountiny commentedon Jul 22, 2024
And it seems like its a combination with #45370 cc @dominictb @thesahindia
francoisl commentedon Jul 22, 2024
This is also fixed by reverting #45370 for me locally.
3 remaining items
[-]Thread - Error shows up when user sends a message after leaving the thread[/-][+][HOLD for payment 2024-08-01] Thread - Error shows up when user sends a message after leaving the thread[/+]melvin-bot commentedon Jul 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
melvin-bot commentedon Aug 1, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Aug 5, 2024
@roryabraham Huh... This is 4 days overdue. Who can take care of this?