Repository navigation
Expense - Logo in Share code for transaction thread is not Expensify logo #45827
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #39072
Action Performed:
- Go to staging.new.expensify.com
- Go to DM with no unsettled expense
- Submit an expense
- Click on the expense preview
- Click report header > Share
- Note that the logo in share code is Expensify logo
- Create another expense
- Go to transaction thread
- Click report header > Share
Expected Result:
Logo in Share code for transaction thread is Expensify logo
Actual Result:
Logo in Share code for transaction thread is not Expensify logo, It follows the individual policy avatar
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
github-actions commentedon Jul 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.mountiny commentedon Jul 21, 2024
@Kicu @grgia @blazejkustra @luacmartins @sobitneupane Seems like this might be coming from your PR #39072 can you have a look please?
Ultimately I think this could be demoted as its a minor UI issue that does not block the user
Kicu commentedon Jul 22, 2024
Hey thanks for calling us. Yes this is definitely coming from my PR #39072
However you can take a look at this comment from @shawnborton #39072 (comment)
He suggested we move forward with switching the current expectation of using expensify logo to using the same logo as in header.
Now the app is not yet 100% ready to do this (we need 1 more PR) but there are parts of the app that will already show the avatar, so I think this should be deemed a not bug.
Please comment on this @shawnborton
shawnborton commentedon Jul 22, 2024
Correct, this is not a bug - we want to move towards a world where the avatar found in the share code always matches either the user's avatar, the workspace avatar, or the avatar found in the chat header. I can close this out, this is not a deploy blocker.
shawnborton commentedon Jul 22, 2024
@Kicu what are next steps to make this work everywhere though? Do we have that spelled out anywhere, and do we need a new issue to track this? Happy to make one if so, just let me know!
Kicu commentedon Jul 22, 2024
I believe the main thing I need is a new issue defined be someone so that I can get assigned to it.
I don't think I need any detailed definition other than "make the avatar inside QR code the same as in header".
The issue would also be a place to discuss any edge cases that might arise while doing that (I'm not yet sure simple this task will be, probably simple-to-mid-complex).
shawnborton commentedon Jul 22, 2024
Sounds good, I'll make the new issue now.