Repository navigation
[HOLD for payment 2024-08-01] Thread – Join button reappears in header when try to join thread after leave it #45828
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.10-2
Reproducible in staging?: yes
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4747620
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:
Action Performed:
- Go to https://staging.new.expensify.com/
- Log in
- Open chat with user B
- Send a message
- Right click and select Reply in thread
- Send a comment in the thread
- Click on header
- Click on Leave thread
- Click on Join thread button on the header
Expected Result:
Join button disappears, user joined to thread
Actual Result:
Join button reappears, user is not joined to thread
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon Jul 22, 2024
@bernhardoj @akinwale Seems like this might be related to #45136 maybe we should revert the PR and cover these newly found edge cases
francoisl commentedon Jul 22, 2024
Confirmed that it comes from #45370 as suggested here by reverting it locally.
/cc @dominictb @thesahindia if you can think of a fix. In the meantime I'll prepare a revert CP just in case.
francoisl commentedon Jul 22, 2024
Going to go ahead with the revert for now.
[-]Thread – Join button reappears in header when try to join thread after leave it[/-][+][HOLD for payment 2024-08-01] Thread – Join button reappears in header when try to join thread after leave it[/+]melvin-bot commentedon Jul 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
melvin-bot commentedon Jul 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
CortneyOfstad commentedon Jul 31, 2024
No payment is needed as this was internal and a C+ was not assigned due to comment here. Closing!