Skip to content

[HOLD for payment 2024-08-14] Report fields - Offline indicator appears below the content when edit to fields is disabled #45847

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #44672
Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • Workspace is connected to Sage Intacct.
  • Workspace has List type report fields by importing Departments as report fields in Accounting > Import settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Report fields.
  3. Click on the List type report field (Departments) which is imported from Sage Intacct.
  4. Go offline.

Expected Result:

Offline indicator will appear at the page bottom.

Actual Result:

Offline indicator appears below the content.
NOTE: This issue only happens when changes to report fields are disabled via connection to Accountings.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6548205_1721491243056.ScreenRecording_07-20-2024_23-47-17_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight / @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 20, 2024
  2. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Jul 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. m-natarajan commented on Jul 20, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-control

  6. 29 remaining items

  7. shubham1206agra commented on Jul 29, 2024

    @shubham1206agra
    Contributor

    PR is up for review.

  8. garrettmknight commented on Aug 7, 2024

    @garrettmknight
    Contributor

    We're on staging! @abekkala I'll take this one back over, thanks for the help!

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 7, 2024
  10. changed the title [-]Report fields - Offline indicator appears below the content when edit to fields is disabled[/-] [+][HOLD for payment 2024-08-14] Report fields - Offline indicator appears below the content when edit to fields is disabled[/+] on Aug 7, 2024
  11. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-14. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  14. mountiny commented on Aug 8, 2024

    @mountiny
    Contributor

    I think we can close this one as payments will be handled together for the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions