You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-14] Report fields - Offline indicator appears below the content when edit to fields is disabled #45847
Issue found when validating #44672 Version Number: 9.0.10-2 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Precondition:
Workspace is connected to Sage Intacct.
Workspace has List type report fields by importing Departments as report fields in Accounting > Import settings.
Go to staging.new.expensify.com
Go to workspace settings > Report fields.
Click on the List type report field (Departments) which is imported from Sage Intacct.
Go offline.
Expected Result:
Offline indicator will appear at the page bottom.
Actual Result:
Offline indicator appears below the content.
NOTE: This issue only happens when changes to report fields are disabled via connection to Accountings.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Report fields - Offline indicator appears below the content when edit to fields is disabled[/-][+][HOLD for payment 2024-08-14] Report fields - Offline indicator appears below the content when edit to fields is disabled[/+]on Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight / @abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 20, 2024
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.m-natarajan commentedon Jul 20, 2024
We think that this bug might be related to #wave-control
29 remaining items
shubham1206agra commentedon Jul 29, 2024
PR is up for review.
garrettmknight commentedon Aug 7, 2024
We're on staging! @abekkala I'll take this one back over, thanks for the help!
[-]Report fields - Offline indicator appears below the content when edit to fields is disabled[/-][+][HOLD for payment 2024-08-14] Report fields - Offline indicator appears below the content when edit to fields is disabled[/+]melvin-bot commentedon Aug 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Aug 8, 2024
I think we can close this one as payments will be handled together for the project