[HOLD for payment 2024-08-02] Dupe detect - Billable toggle on confirm page does not reflect the selection on discrepancy page

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Billable feature is enabled on Old Dot.

Go to staging.new.expensify.com
Go to workspace chat
Submit two expenses - Both have the same amount and merchant, but one has enabled billable toggle and the other has disabled billable toggle
Go to transaction thread of the expense that has disabled billable option
Click Review duplicates
Select Keep this one (any)
On "Choose if transaction is billable", select Yes.8. Proceed to confirmation page

Expected Result:

Billable toggle should be enabled as user has chosen Yes on "Choose if transaction is billable" step

Actual Result:

Billable toggle remains disabled on confirmation page when user has chosen Yes on "Choose if transaction is billable" step

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6548593_1721559579725.bandicam_2024-07-21_18-46-18-580.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

@yuwenmemon

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Billable toggle remains disabled on confirmation page when user has chosen Yes on "Choose if transaction is billable" step

What is the root cause of that problem?

In:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 635 in f3a8f73

isOn={!!transactionBillable}

we do not use the billable data from updatedTransaction

What changes do you think we should make in order to solve the problem?

Should update it to:

                            isOn={updatedTransaction?.billable ?? !!transactionBillable}

@JmillsExpensify

The dupe detection is behind beta so we can demote

@JmillsExpensify @pecanoro @kubabutkiewicz @parasharrajat

@kubabutkiewicz

@kubabutkiewicz Let's fix this on your PR.

@yuwenmemon

@yuwenmemon I am reassigning the issue to myself so I can review and track the fixes since this is for the duplicate detection project that I am handling.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Polish: Dupe detection #45890

If no regressions arise, payment will be issued on 2024-08-02. 🎊

@pecanoro

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
[@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@pecanoro] Determine if we should create a regression test for this bug.
[@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@JmillsExpensify

@JmillsExpensify, @pecanoro Eep! 4 days overdue now. Issues have feelings too...

Payment is being handled in another issue, so going to close this one out.

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-02] Dupe detect - Billable toggle on confirm page does not reflect the selection on discrepancy page #45864

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-02] Dupe detect - Billable toggle on confirm page does not reflect the selection on discrepancy page #45864

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 21, 2024

github-actions commented on Jul 21, 2024

dominictb commented on Jul 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mountiny commented on Jul 22, 2024

parasharrajat commented on Jul 22, 2024

pecanoro commented on Jul 22, 2024

13 remaining items

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Aug 2, 2024

melvin-bot commented on Aug 6, 2024

JmillsExpensify commented on Aug 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions