You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] LHN-Archived workspace shows green dot in LHN. #45881
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
@srikarparsi Thanks for your feedback. I still have a concern here. report.private_isArchived is only a temporary here #45568 while isArchivedRoom always correct even we will be removed in the further since it's used isArchivedRoom function. Using it can also reduce the number of calls to the isArchivedRoom function and getReportNameValuePairs
Yeah I see what you're saying but I don't think we should ever have two properties that point to the same value (private_isArchived and isArchivedRoom in OptionReport). I agree that switching over to private_isArchived will require more changes once we switch private_isArchived to be a part of the reportNameValuePairs collection but I think it's a better approach as it avoids redundant variables.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 22, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 22, 2024
We think this issue might be related to the #vip-vsb
izarutskaya commentedon Jul 22, 2024
Production
video_2024-07-22_10-09-35.mp4
53 remaining items
melvin-bot commentedon Aug 6, 2024
📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
nkdengineer commentedon Aug 6, 2024
@srikarparsi Thanks for your feedback. I still have a concern here.
report.private_isArchivedis only a temporary here #45568 whileisArchivedRoomalways correct even we will be removed in the further since it's usedisArchivedRoomfunction. Using it can also reduce the number of calls to theisArchivedRoomfunction andgetReportNameValuePairsFinally, I'm happy with your decision.
srikarparsi commentedon Aug 6, 2024
Yeah I see what you're saying but I don't think we should ever have two properties that point to the same value (
private_isArchivedandisArchivedRoomin OptionReport). I agree that switching over toprivate_isArchivedwill require more changes once we switchprivate_isArchivedto be a part of thereportNameValuePairscollection but I think it's a better approach as it avoids redundant variables.nkdengineer commentedon Aug 6, 2024
Thanks.
melvin-bot commentedon Aug 30, 2024
This issue has not been updated in over 15 days. @abekkala, @srikarparsi, @situchan, @cretadn22 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
cretadn22 commentedon Sep 30, 2024
@abekkala It is time to process payment. We have deployed the PR to production since Sep 20
abekkala commentedon Oct 2, 2024
@situchan @cretadn22 paymetns sent and contracts ended - thank you! 🎉