Skip to content

[$250] LHN-Archived workspace shows green dot in LHN. #45881

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4751910
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch app
  2. Tap fab - create a new workspace
  3. Tap on workspace chat
  4. Submit a expense using plus icon near compose
  5. Navite to LHN and note green dot next to workspace chat
  6. Tap profile icon -- workspaces -- workspace
  7. Tap 3 dots next to workspace and delete the workspace
  8. Navigate to LHN

Expected Result:

Archived workspace must not show green dot in LHN.

Actual Result:

Archived workspace shows green dot in LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6548982_1721612000550.dot.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017beae0c789f3f2ea
  • Upwork Job ID: 1816740887268923324
  • Last Price Increase: 2024-08-02
  • Automatic offers:
    • situchan | Reviewer | 103412587
    • cretadn22 | Contributor | 103412589
Issue OwnerCurrent Issue Owner: @situchan

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 22, 2024
  2. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 22, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 22, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb

  6. izarutskaya commented on Jul 22, 2024

    @izarutskaya
    Author

    Production

    video_2024-07-22_10-09-35.mp4
  7. 53 remaining items

  8. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  9. nkdengineer commented on Aug 6, 2024

    @nkdengineer
    Contributor

    @srikarparsi Thanks for your feedback. I still have a concern here. report.private_isArchived is only a temporary here #45568 while isArchivedRoom always correct even we will be removed in the further since it's used isArchivedRoom function. Using it can also reduce the number of calls to the isArchivedRoom function and getReportNameValuePairs

    Finally, I'm happy with your decision.

  10. srikarparsi commented on Aug 6, 2024

    @srikarparsi
    Contributor

    Yeah I see what you're saying but I don't think we should ever have two properties that point to the same value (private_isArchived and isArchivedRoom in OptionReport). I agree that switching over to private_isArchived will require more changes once we switch private_isArchived to be a part of the reportNameValuePairs collection but I think it's a better approach as it avoids redundant variables.

  11. nkdengineer commented on Aug 6, 2024

    @nkdengineer
    Contributor

    Thanks.

  12. added
    ReviewingHas a PR in review
    and removed on Aug 7, 2024
  13. melvin-bot commented on Aug 30, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @abekkala, @srikarparsi, @situchan, @cretadn22 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. cretadn22 commented on Sep 30, 2024

    @cretadn22
    Contributor

    @abekkala It is time to process payment. We have deployed the PR to production since Sep 20

  15. abekkala commented on Oct 2, 2024

    @abekkala
    Contributor

    @situchan @cretadn22 paymetns sent and contracts ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions