Repository navigation
[$250] When we set description of a room for the first time, optimistically it is shown as a comment in the LHN and later updates to system message #46046
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721729123500449
Action Performed:
- Create a room
- Click on room heading
- Go to description and set description
- Observe in LHN that the exact description entered is shown first then it updates to system message
Expected Result:
Description entered is displayed
Actual Result:
Description entered is shown first then it updates to system message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Screen.Recording.2024-07-23.at.3.35.05.PM.mov
Add any screenshot/video evidence
Recording.381.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d1a09eb334a44e74
- Upwork Job ID: 1816626243288402483
- Last Price Increase: 2024-08-08
- Automatic offers:
- allgandalf | Contributor | 103318023
- FitseTLT | Contributor | 103373101
Activity
melvin-bot commentedon Jul 23, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.FitseTLT commentedon Jul 23, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
When we set description of a room for the first time, optimistically it is shown as a comment in the LHN and later updates to system message
What is the root cause of that problem?
Because we do not create an optimistic action (room description updated type of action) in updateDescription the LHN will default to show the description as there will no be any report action until the room update report action is returned from the server.
What changes do you think we should make in order to solve the problem?
We need to create an optimistic room description updated report action in updateDescription.
We should do similar thing as we did for creating room name updated optimistic report action in here
App/src/libs/actions/Report.ts
Lines 2239 to 2262 in a3df238
We create a similar util function as buildOptimisticRenamedRoomReportAction which takes new description as a param and creates a
UPDATEROOMDESCRIPTIONreport action with the same content as would be returned from the server. And we then update the optimistic, success and failure data accordingly to include the optimistically created report action.Work expected from the BE : the
UPDATE_ROOM_DESCRIPTIONapi should start acceptingreportActionIDso that it will use the optimistically created reportActionID. Then we will pass the report Action ID as a parameter.What alternative solutions did you explore? (Optional)
allgandalf commentedon Jul 23, 2024
Note
I can take this as a C+ as i reported this issue and have more context
VictoriaExpensify commentedon Jul 26, 2024
Recreated the issue. Agree this is buggy and we should fix it
melvin-bot commentedon Jul 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01d1a09eb334a44e74
[-]When we set description of a room for the first time, optimistically it is shown as a comment in the LHN and later updates to system message[/-][+][$250] When we set description of a room for the first time, optimistically it is shown as a comment in the LHN and later updates to system message[/+]melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)40 remaining items
allgandalf commentedon Aug 12, 2024
PR was raised, today, I will review it soon
allgandalf commentedon Aug 14, 2024
Approved the PR, all yours @marcochavezf 🙇
allgandalf commentedon Aug 16, 2024
PR is on staging ♻️
allgandalf commentedon Aug 27, 2024
The PR that introduced the bug has been identified. Link to the PR: Migrate welcome message to room description for report #34150
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34150/files#r1732202908
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Verify that 'the room description updated' system message is shown
Verify also that the same system message is shown in LHN
Do we agree 👍 or 👎
allgandalf commentedon Aug 27, 2024
@VictoriaExpensify can you pay this one please 🙇
melvin-bot commentedon Aug 27, 2024
Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.
VictoriaExpensify commentedon Aug 27, 2024
Created a GH to add this to TestRail - https://github.com/Expensify/Expensify/issues/423524
VictoriaExpensify commentedon Aug 27, 2024
Payment Summary:
Contributor: @FitseTLT paid $250 via Upwork
Contributor+: @allgandalf paid $250 via Upwork
Thanks for your work on this!