Repository navigation
[HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] Desktop - App - App font is different on staging #46048
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Launch New Expensify desktop app
- Log in
- Navigate through the app
Expected Result:
The font will be the same as the font on prod
Actual Result:
The app font is different on staging
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jul 23, 2024
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
francoisl commentedon Jul 23, 2024
Hmm weird. I can reproduce the issue. On the production app, if you look at the Preview tab of the request to load the fonts, it will display an actual preview of the fonts:
On the staging app, it shows some garbled stuff, like the font was corrupted or interpreted in the wrong content-type
francoisl commentedon Jul 23, 2024
Ah yes, it does appear to be a Content-Type issue. Staging interprets it as
text/htmlvsapplication/octet-streamfor prodAt first glance, nothing in the checklist looks out of the ordinary that could explain this.
francoisl commentedon Jul 23, 2024
I think this is coming from #44432, that PR modified a bunch of stuff in
desktop/. I tried an ad-hoc build after reverting it on this PR and it resolves the issue.https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/46070/NewExpensify.dmg
francoisl commentedon Jul 23, 2024
cc @kirillzyusko @jayeshmangwani if you have any ideas about the above.
5 remaining items
[-]Desktop - App - App font is different on staging[/-][+][HOLD for payment 2024-08-01] Desktop - App - App font is different on staging[/+]melvin-bot commentedon Jul 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
[-][HOLD for payment 2024-08-01] Desktop - App - App font is different on staging[/-][+][HOLD for payment 2024-08-02] [HOLD for payment 2024-08-01] Desktop - App - App font is different on staging[/+]melvin-bot commentedon Jul 26, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 26, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-02. 🎊