[HOLD for payment 2024-08-09] [$250] Threads - Leaving from multilevel threads navigates to wrong thread

@mananjadhav

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): bezawitgebremichael+kkii@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to staging.new.expensify.com
Open a chat
Send a message (Name it parent message for easier observation)
Hover over the message and click on reply in thread
Send another message in the thread (Name it thread 1 for easier observation)
Hover over the message and click on reply in thread
Send another message in the thread (Name it thread 2 for easier observation)
Click on the header of the thread
Click on leave
Note the name of the header and click on it
Click on leave
Note the name of the header and wait a few seconds

Expected Result:

When leaving the first level thread app navigates user to the parent thread, when leaving from the parent thread app navigates to the Original chat and no "You don't have access to this chat" page is displayed

Actual Result:

When leaving the first level thread app navigates to the parent thread but when leaving the parent thread again the app navigates user back to the first level thread and then after a few seconds "You don't have access to this chat" page is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6550339_1721722658336.bandicam_2024-07-23_11-02-57-895.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a17100bfa3035f8c
Upwork Job ID: 1816165199632115677
Last Price Increase: 2024-07-24

Issue Owner

Current Issue Owner: @mananjadhav

@marcaaron

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #vip-vsp

Proposal

Please re-state the problem that we are trying to solve in this issue.

Leaving from multilevel threads navigates to wrong thread

What is the root cause of that problem?

On leave action we always navigate to the most recent report/the last accessed report here

App/src/libs/actions/Report.ts

Line 2706 in 2bb1d00

navigateToMostRecentReport(report);

What changes do you think we should make in order to solve the problem?

If parentReportID exist navigate to the parent report instead of the most recent report

    if (report.parentReportID) {
        const parentReportRoute = ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID);
        Navigation.goBack(parentReportRoute);
    }else{
        navigateToMostRecentReport(report);
    }

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

When leaving the first level thread app navigates to the parent thread but when leaving the parent thread again the app navigates user back to the first level thread and then after a few seconds "You don't have access to this chat" page is displayed

What is the root cause of that problem?

When leaving room, we always call:

App/src/libs/actions/Report.ts

Line 2790 in 2bb1d00

navigateToMostRecentReport(report);

That function get the most recent access report based on:

App/src/libs/ReportUtils.ts

Lines 1209 to 1214 in 2bb1d00

    
           function getMostRecentlyVisitedReport(reports: Array<OnyxEntry<Report>>, reportMetadata: OnyxCollection<ReportMetadata>): OnyxEntry<Report> { 
        
               const filteredReports = reports.filter( 
        
                   (report) => !!report?.reportID && !!(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`]?.lastVisitTime ?? report?.lastReadTime), 
        
               ); 
        
               return lodashMaxBy(filteredReports, (a) => new Date(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${a?.reportID}`]?.lastVisitTime ?? a?.lastReadTime ?? '').valueOf()); 
        
           }

without filtering the leaved thread, lead to the loop behavior: Assume we have two thread 1 and 2. Access 1 then access 2. Now leave thread 2. User is moved to thread 1. Then leave thread 1. User is moved to thread 2. And then join thread 2. Then leave thread 2. User is moved to thread 1, ...

What changes do you think we should make in order to solve the problem?

We should filter the leaved report from above:

function getMostRecentlyVisitedReport(reports: Array<OnyxEntry<Report>>, reportMetadata: OnyxCollection<ReportMetadata>, shouldKeepLeavedThread = true): OnyxEntry<Report> {
    const filteredReports = reports.filter((report) => {
        const shouldKeep = shouldKeepLeavedThread || !isChatThread(report) || (isChatThread(report) && report?.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN);
        return shouldKeep && !!report?.reportID && !!(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`]?.lastVisitTime ?? report?.lastReadTime);
    });
    return lodashMaxBy(filteredReports, (a) => new Date(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${a?.reportID}`]?.lastVisitTime ?? a?.lastReadTime ?? '').valueOf());
}

When leaving room, we use shouldKeepLeavedThread : false to make sure this change does not break other logic.

Thanks for the proposals. Can you identify which PR from the checklist introduced this issue?

Job added to Upwork: https://www.upwork.com/jobs/~01a17100bfa3035f8c

Checklist

https://github.com/Expensify/App/pull/44948/files
https://github.com/Expensify/App/pull/44948/files#r1713856786
N/A
A regression test would be helpful.

Regression Test

Navigate to the app and Open a chat
Send a message (Name it parent message for easier observation)
Hover over the message and click on reply in thread
Send another message in the thread (Name it thread 1 for easier observation)
Hover over the message and click on reply in thread
Send another message in the thread (Name it thread 2 for easier observation)
Click on the header of the thread and click on leave
Note the name of the header and click on it, and click on leave

Verify that when leaving the first level thread app navigates user to the parent thread, when leaving from the parent thread app navigates to the Original chat and no "You don't have access to this chat" page is displayed

Do we 👍 or 👎 ?

@daledah

Payouts due:

Contributor: $250 @daledah (bumping the above message - will you apply to the Upwork Job?)
Contributor+: $250 @allroundexperts (NewDot)

Upwork job is here.

@daledah

Bump @daledah!

@adelekennedy

Sorry @adelekennedy I don't have any Upwork Connects so I could not apply to the job. Instead, could you send the offer directly to my profile here https://www.upwork.com/freelancers/~0138d999529f34d33f. TY

@allroundexperts

@allroundexperts, @marcaaron, @adelekennedy, @daledah Whoops! This issue is 2 days overdue. Let's get this updated quick!

@daledah

hired @daledah!

@adelekennedy

@adelekennedy I have accepted, thank you

@allroundexperts

$250 approved for @allroundexperts

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-09] [$250] Threads - Leaving from multilevel threads navigates to wrong thread #46085

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

37 remaining items

Checklist

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function getMostRecentlyVisitedReport(reports: Array<OnyxEntry<Report>>, reportMetadata: OnyxCollection<ReportMetadata>): OnyxEntry<Report> {
	const filteredReports = reports.filter(
	(report) => !!report?.reportID && !!(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${report.reportID}`]?.lastVisitTime ?? report?.lastReadTime),
	);
	return lodashMaxBy(filteredReports, (a) => new Date(reportMetadata?.[`${ONYXKEYS.COLLECTION.REPORT_METADATA}${a?.reportID}`]?.lastVisitTime ?? a?.lastReadTime ?? '').valueOf());
	}

[HOLD for payment 2024-08-09] [$250] Threads - Leaving from multilevel threads navigates to wrong thread #46085

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 23, 2024

github-actions commented on Jul 23, 2024

lanitochka17 commented on Jul 23, 2024

nyomanjyotisa commented on Jul 24, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

daledah commented on Jul 24, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

francoisl commented on Jul 24, 2024

melvin-bot commented on Jul 24, 2024

37 remaining items

allroundexperts commented on Aug 12, 2024

Checklist

Regression Test

adelekennedy commented on Aug 14, 2024

adelekennedy commented on Aug 15, 2024

daledah commented on Aug 16, 2024

melvin-bot commented on Aug 20, 2024

adelekennedy commented on Aug 21, 2024

daledah commented on Aug 21, 2024

JmillsExpensify commented on Oct 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions