Repository navigation
Report field - Show violation on single transaction expense reports #46215
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating #44139
Version Number: 9.0.12.0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Precondition:
- Workspace is under Control plan.
- Report fields feature is enabled.
- Text type report field is added and it has no initial value.
- The workspace has no unsettled expense.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Submit a manual expense.
- Go to expense report.
- Note that report field violations do not show up.
- Submit another manual expense.
- Note that report field violation shows up.
- Go to Troubleshoot > Clear cache and restart > Reset and restart.
- Go to expense report.
- Note that report field violations disappear..
Expected Result:
In Step 5, report field violation will show up after submitting the first expense.
In Step 10, report field violation will persist after clearing cache and restarting app.
Actual Result:
In Step 5, report field violation does not show up after submitting the first expense.
It only shows up after submitting the second expense (Step 7).
In Step 10, report field violation disappears after clearing cache and restarting app.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
AndrewGable commentedon Jul 25, 2024
@thienlnam @jnowakow @war-in @blazejkustra @allroundexperts - Can you check into this?
9 remaining items
war-in commentedon Jul 29, 2024
I think I found the cause of the issue: #46425
When the first expense was created we dealt with an optimistic IOU report and there was no
fieldListfield in it. If thefieldListis undefined we can't tell which fields were violated.I added
fieldListto theOptimisticIOUReportandOptimisticExpenseReporttypes. That way we can optimistically setfieldList🎉I'll mark PR as ready for review tomorrow because I need to test it and record videos
war-in commentedon Jul 31, 2024
PR is ready for C+ review :)
cc @allroundexperts
melvin-bot commentedon Aug 23, 2024
This issue has not been updated in over 15 days. @thienlnam, @kadiealexander, @war-in eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
allroundexperts commentedon Aug 23, 2024
Can I get assigned here since I reviewed the PR?
thienlnam commentedon Aug 26, 2024
Yeah, but this was a regression from #44139
allroundexperts commentedon Oct 8, 2024
My bad. This can be closed. You're correct @thienlnam