You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Guided Setup] [$250] Replace Enable your wallet with Add personal bank account task during onboarding #46231
There are two intents Get paid back by my employer and Chat and split bills with friends where one of the onboading tasks we show is Enable your wallet. But the wallet flow is onerous and we actually have not cleaned it up to show clear and actionable error messages and this is not a priority either till more people use IOU payments.
So for now, let's replace this task with a Add personal bank account
Title: Add personal bank account Description:
You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!
Here’s how to set up your bank account:
Click your profile picture.
Click Wallet > Bank accounts > + Add bank account.
Connect your bank account.
Once that’s done, you can request money from anyone and get paid back right into your personal bank account.
changed the title [-]Replace Enable your wallet with Add personal bank account task during onboarding[/-][+][$250] Replace Enable your wallet with Add personal bank account task during onboarding[/+]on Jul 25, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
No offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be good!
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Login with new account
Choose 'Get paid back by my employer or 'Chat and split bills with' on onboarding
Enter your name
Verify that 'Add personal bank account' task exist in Concierge chat
👍 or 👎
@kadiealexander The PR is deployed to production last week, could you give the payment summary? Thank you!
Activity
melvin-bot commentedon Jul 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01a9b5735e8551a25a
[-]Replace Enable your wallet with Add personal bank account task during onboarding[/-][+][$250] Replace Enable your wallet with Add personal bank account task during onboarding[/+]melvin-bot commentedon Jul 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)melvin-bot commentedon Jul 25, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
80 remaining items
melvin-bot commentedon Aug 26, 2024
@tgolen, @mollfpr, @kadiealexander, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!
mollfpr commentedon Aug 26, 2024
@nyomanjyotisa Could you create the new PR? Thanks!
kadiealexander commentedon Aug 28, 2024
@nyomanjyotisa bump!
nyomanjyotisa commentedon Aug 28, 2024
@mollfpr PR is ready for review, sorry for the delay 🙏
VictoriaExpensify commentedon Sep 13, 2024
@mollfpr - have you had a chance to review this yet?
mollfpr commentedon Sep 16, 2024
@VictoriaExpensify The changes on the PR look good to me! We are waiting for the BE changes to make the task auto mark working.
mollfpr commentedon Sep 26, 2024
No offending PR.
The regression step should be good!
@kadiealexander The PR is deployed to production last week, could you give the payment summary? Thank you!
kadiealexander commentedon Oct 14, 2024
Payouts due:
Upwork job is here.
garrettmknight commentedon Oct 15, 2024
$250 approved for @mollfpr