Skip to content

[Guided Setup] [$250] Replace Enable your wallet with Add personal bank account task during onboarding #46231

Closed

Description

@anmurali

There are two intents Get paid back by my employer and Chat and split bills with friends where one of the onboading tasks we show is Enable your wallet. But the wallet flow is onerous and we actually have not cleaned it up to show clear and actionable error messages and this is not a priority either till more people use IOU payments.

So for now, let's replace this task with a Add personal bank account

image

Title: Add personal bank account
Description:

You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!
Here’s how to set up your bank account:

  1. Click your profile picture.
  2. Click Wallet > Bank accounts > + Add bank account.
  3. Connect your bank account.

Once that’s done, you can request money from anyone and get paid back right into your personal bank account.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a9b5735e8551a25a
  • Upwork Job ID: 1816570512509995571
  • Last Price Increase: 2024-07-25
  • Automatic offers:
    • nyomanjyotisa | Contributor | 103281558
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 25, 2024
  2. melvin-bot commented on Jul 25, 2024

    @melvin-bot
  3. changed the title [-]Replace Enable your wallet with Add personal bank account task during onboarding[/-] [+][$250] Replace Enable your wallet with Add personal bank account task during onboarding[/+] on Jul 25, 2024
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 25, 2024
  5. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  6. added and removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 25, 2024
  7. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    NewFeatureSomething to build that is a new item.
    on Jul 25, 2024
  9. 80 remaining items

  10. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    @tgolen, @mollfpr, @kadiealexander, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. mollfpr commented on Aug 26, 2024

    @mollfpr
    Contributor

    @nyomanjyotisa Could you create the new PR? Thanks!

  12. kadiealexander commented on Aug 28, 2024

    @kadiealexander
    Contributor
  13. nyomanjyotisa commented on Aug 28, 2024

    @nyomanjyotisa
    Member

    @mollfpr PR is ready for review, sorry for the delay 🙏

  14. VictoriaExpensify commented on Sep 13, 2024

    @VictoriaExpensify
    Contributor

    @mollfpr - have you had a chance to review this yet?

  15. mollfpr commented on Sep 16, 2024

    @mollfpr
    Contributor

    @VictoriaExpensify The changes on the PR look good to me! We are waiting for the BE changes to make the task auto mark working.

  16. mollfpr commented on Sep 26, 2024

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    No offending PR.

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression step should be good!

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Login with new account
    2. Choose 'Get paid back by my employer or 'Chat and split bills with' on onboarding
    3. Enter your name
    4. Verify that 'Add personal bank account' task exist in Concierge chat
    5. 👍 or 👎

    @kadiealexander The PR is deployed to production last week, could you give the payment summary? Thank you!

  17. kadiealexander commented on Oct 14, 2024

    @kadiealexander
    Contributor

    Payouts due:

    Upwork job is here.

  18. moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Oct 14, 2024
  19. garrettmknight commented on Oct 15, 2024

    @garrettmknight
    Contributor

    $250 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions