Skip to content

Android - Profile - Selected pronoun is not visible in the "Preferred Pronouns" field #4628

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with account you don't have last and first name setsup up.
  3. Go to Settings - Profile
  4. On Preferred Pronouns dropdown field select any.

Expected Result:

I expected to see the selected option in my profile.

Actual Result:

Selected the option in the "Preferred Pronouns" isn't visible in the field.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.0.85-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5190778_Screen_Recording_20210812-135805_Expensifycash.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

Activity

  1. OSBotify commented on Aug 12, 2021

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. MelvinBot commented on Aug 12, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. kakajann commented on Aug 13, 2021

    @kakajann
    Contributor

    Hi, I just investigated and found this

    Apperantly, this is a react-native-picker-selects bug. And passing color style for Picker solves the issue.

    I can open a PR

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 13, 2021
  5. MelvinBot commented on Aug 13, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. self-assigned this
    on Aug 13, 2021
  7. roryabraham commented on Aug 13, 2021

    @roryabraham
    Contributor

    Great find @kakajann! Feel free to submit a PR, and we'll get an Upwork job created for you ASAP.

  8. 6 remaining items

  9. roryabraham commented on Aug 13, 2021

    @roryabraham
    Contributor

    Reopening pending payment

  10. added
    ReviewingHas a PR in review
    and removed on Aug 13, 2021
  11. roryabraham commented on Aug 13, 2021

    @roryabraham
    Contributor

    @kakajann @roryabraham would you say this issue was caused by @kakajann 's PR #3414? It looks related since that PR created the expensiPicker style, which is all that was changed in the PR that fixed this issue

    @Beamanator that's a good point

  12. roryabraham commented on Aug 14, 2021

    @roryabraham
    Contributor

    @kavimuru This should be fixed in v1.0.85-5+

  13. isagoico commented on Aug 14, 2021

    @isagoico

    #4554 (comment) retest was a pass, closing.

  14. jliexpensify commented on Aug 20, 2021

    @jliexpensify
    Contributor

    @roryabraham and @Beamanator - apologies, I'm just a little confused: should I be paying @kakajann for this job? The previous comments indicate not, correct?

  15. roryabraham commented on Aug 20, 2021

    @roryabraham
    Contributor

    Okay, so reviewing what happened here:

    1. @kakajann submitted PR: Create custom TextInput #3414, which caused a regression.
    2. @kakajann quickly volunteered to fix the regression.
    3. I failed to notice that the regression was caused by Create custom TextInput #3414, and agreed to create a new Upwork job and hire @kakajann to fix the regression. This was a mistake on my part.

    However, since #3414 caused the regression, it was already @kakajann's responsibility to fix the regression. So a second job should have never been created. Therefore, I don't think we should pay out the second job.

    This is a situation I have personally never been in with a contributor before, so as far as I know we don't have a precedent se here, but it seems fair to me. @kakajann please let us know if you disagree.

  16. kakajann commented on Aug 20, 2021

    @kakajann
    Contributor

    I don't mind to end the contract from upwork. I wasn't aware this issue is my regression.

  17. jliexpensify commented on Aug 20, 2021

    @jliexpensify
    Contributor

    Thanks for your understanding and for accepting this outcome @kakajann . Contract has been cancelled in Upwork.

    Hope to work with you again soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions