You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Profile - Selected pronoun is not visible in the "Preferred Pronouns" field #4628
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@kakajann@roryabraham would you say this issue was caused by @kakajann 's PR #3414? It looks related since that PR created the expensiPicker style, which is all that was changed in the PR that fixed this issue
@roryabraham and @Beamanator - apologies, I'm just a little confused: should I be paying @kakajann for this job? The previous comments indicate not, correct?
@kakajann quickly volunteered to fix the regression.
I failed to notice that the regression was caused by Create custom TextInput #3414, and agreed to create a new Upwork job and hire @kakajann to fix the regression. This was a mistake on my part.
However, since #3414 caused the regression, it was already @kakajann's responsibility to fix the regression. So a second job should have never been created. Therefore, I don't think we should pay out the second job.
This is a situation I have personally never been in with a contributor before, so as far as I know we don't have a precedent se here, but it seems fair to me. @kakajann please let us know if you disagree.
Activity
OSBotify commentedon Aug 12, 2021
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Aug 12, 2021
Triggered auto assignment to @ctkochan22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kakajann commentedon Aug 13, 2021
Hi, I just investigated and found this
Apperantly, this is a
react-native-picker-selects bug. And passing color style for Picker solves the issue.I can open a PR
MelvinBot commentedon Aug 13, 2021
Triggered auto assignment to @jliexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.roryabraham commentedon Aug 13, 2021
Great find @kakajann! Feel free to submit a PR, and we'll get an Upwork job created for you ASAP.
6 remaining items
roryabraham commentedon Aug 13, 2021
Reopening pending payment
roryabraham commentedon Aug 13, 2021
@Beamanator that's a good point
roryabraham commentedon Aug 14, 2021
@kavimuru This should be fixed in v
1.0.85-5+isagoico commentedon Aug 14, 2021
#4554 (comment) retest was a pass, closing.
jliexpensify commentedon Aug 20, 2021
@roryabraham and @Beamanator - apologies, I'm just a little confused: should I be paying @kakajann for this job? The previous comments indicate not, correct?
roryabraham commentedon Aug 20, 2021
Okay, so reviewing what happened here:
However, since #3414 caused the regression, it was already @kakajann's responsibility to fix the regression. So a second job should have never been created. Therefore, I don't think we should pay out the second job.
This is a situation I have personally never been in with a contributor before, so as far as I know we don't have a precedent se here, but it seems fair to me. @kakajann please let us know if you disagree.
kakajann commentedon Aug 20, 2021
I don't mind to end the contract from upwork. I wasn't aware this issue is my regression.
jliexpensify commentedon Aug 20, 2021
Thanks for your understanding and for accepting this outcome @kakajann . Contract has been cancelled in Upwork.
Hope to work with you again soon!