[HOLD for payment 2024-08-09] [$125] QBO - App crashes when clicking on Card reconciliation immediately after QBO is connected

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Accounting
Connect to QBO
Enter credentials
After being redirected to ND, immediately click on Card reconciliation. (important)

Expected Result:

App will not crash.

Actual Result:

App crashes when clicking on Card reconciliation immediately after QBO is connected

Workaround:

Unknwon

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6554402_1722061152972.20240727_141345.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0139d8c9fe296a0fd9
Upwork Job ID: 1818015645571701690
Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @CortneyOfstad / @miljakljajic

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when clicking on Card reconciliation immediately after QBO is connected.

What is the root cause of that problem?

When autoSync is null/undefined, the below would lead to an exception.

const autoSync = !!policy?.connections?.[connection]?.config?.autoSync.enabled;

What changes do you think we should make in order to solve the problem?

Add option chaining like this:

const autoSync = !!policy?.connections?.[connection]?.config?.autoSync?.enabled ?? false;

We can decide the default value.

Also, the name autoSync can be changed to isAutoSyncEnabled.

Job added to Upwork: https://www.upwork.com/jobs/~0139d8c9fe296a0fd9

@DylanDylann

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@ShridharGoel

Thank you!

@ShridharGoel I hired you to the job - if you accept the contract by tomorrow, I'll get you paid on time - or else @CortneyOfstad will handle next week when she's back

@ShridharGoel

Payment Summary

Upwork Job

ROLE: @ShridharGoel paid $(AMOUNT) via Upwork (LINK)
ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@CortneyOfstad)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1818015645571701690/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@CortneyOfstad

Unassigning myself as @CortneyOfstad is back from OOO

@miljakljajic

Thanks @miljakljajic!

@ShridharGoel looks like it is still waiting for you to accept — please do so as soon as you can!

@CortneyOfstad

@CortneyOfstad, @luacmartins, @ShridharGoel, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@ShridharGoel

Payment Summary

@ShridharGoel — paid $125 via Upwork
@DylanDylann — is not paid for this issue per the comment here

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-09] [$125] QBO - App crashes when clicking on Card reconciliation immediately after QBO is connected #46362

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

20 remaining items

Payment Summary

BugZero Checklist (@CortneyOfstad)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-09] [$125] QBO - App crashes when clicking on Card reconciliation immediately after QBO is connected #46362

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 27, 2024

ShridharGoel commented on Jul 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Jul 29, 2024

melvin-bot commented on Jul 29, 2024

20 remaining items

miljakljajic commented on Aug 8, 2024

melvin-bot commented on Aug 9, 2024

Payment Summary

BugZero Checklist (@CortneyOfstad)

miljakljajic commented on Aug 12, 2024

CortneyOfstad commented on Aug 12, 2024

melvin-bot commented on Aug 15, 2024

CortneyOfstad commented on Aug 19, 2024

Payment Summary

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions