[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit two expenses with same amount and merchant, but one with receipt and one without receipt
Click on the transaction thread of the expense with receipt
Click Review duplicates
Click Keep this one on the expense with receipt
Proceed to confirmation page
Click on the receipt on the confirmation page
Remove the receipt

Expected Result:

Since user is removing the receipt from the confirmation page, the receipt on the actual expense will not be removed, as the changes have not been "confirmed" yet

Actual Result:

When user removes the receipt from the confirmation page, the receipt on the actual expense is also removed, even when the Confirm button is not clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6554746_1722091745819.bandicam_2024-07-27_22-40-17-853.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e50d0c63fac1b4f3
Upwork Job ID: 1818139062818817325
Last Price Increase: 2024-07-30
Automatic offers:

gijoe0295 | Contributor | 103539656

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@anmurali

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 2

Proposal

Please re-state the problem that we are trying to solve in this issue.

When user removes the receipt from the confirmation page, the receipt on the actual expense is also removed, even when the Confirm button is not clicked

What is the root cause of that problem?

We should not allow edit/delete the receipt when in duplicate confirmation page, just like other fields are not editable.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 79 to 82 in 86b923d

    
           <MoneyRequestView 
        
               report={report} 
        
               shouldShowAnimatedBackground={false} 
        
               readonly

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 499 in 9f650ba

interactive={canEditAmount && !readonly}

What changes do you think we should make in order to solve the problem?

To do that, we need to implement a mechanism to pass readonly from MoneyRequestView to TransactionReceipt page. Since they are not within a component tree, we can leverage the route params.

Introduce a new prop readonly to ReportActionItemImage and pass it from MoneyRequestView here
Introduce a new param readonly to TransactionReceipt screen here and its route here
When we navigate to TransactionReceipt screen from ReportActionItemImage here, remember to pass readonly to getRoute
In TransactionReceipt, retrieve the readonly param from route and append to the canEditReceipt condition here to canEditReceipt={canEditReceipt && !readonly}

Proposal Update

Update code permalink
Add detailed explanation to solution and RCA (no changes in general idea)

Edited by proposal-police: This proposal was edited at 2023-10-10T12:34:56Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense

What is the root cause of that problem?

On dupe confirmation page we disable all the field except receipt ReportActionItemImage. We should not allow user to open receipt on confirmation page, this is also the behaviour on submit request confirmation page.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 459 to 468 in 08bb00b

    
           <ReportActionItemImage 
        
               thumbnail={receiptURIs?.thumbnail} 
        
               fileExtension={receiptURIs?.fileExtension} 
        
               isThumbnail={receiptURIs?.isThumbnail} 
        
               image={receiptURIs?.image} 
        
               isLocalFile={receiptURIs?.isLocalFile} 
        
               filename={receiptURIs?.filename} 
        
               transaction={transaction} 
        
               enablePreviewModal 
        
           />

money_request_confrimation.mp4

What changes do you think we should make in order to solve the problem?

We already have enablePreviewModal prop in ReportActionItemImage.tsx which will prevent the app to open modal when enablePreviewModal is false because it renders only ReceiptImage without PressableWithoutFocus.

App/src/components/ReportActionItem/ReportActionItemImage.tsx

Lines 124 to 143 in 08bb00b

    
           if (enablePreviewModal) { 
        
               return ( 
        
                   <ShowContextMenuContext.Consumer> 
        
                       {({report, transactionThreadReport}) => ( 
        
                           <PressableWithoutFocus 
        
                               style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]} 
        
                               onPress={() => 
        
                                   Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(transactionThreadReport?.reportID ?? report?.reportID ?? '-1', transaction?.transactionID ?? '-1')) 
        
                               } 
        
                               accessibilityLabel={translate('accessibilityHints.viewAttachment')} 
        
                               accessibilityRole={CONST.ROLE.BUTTON} 
        
                           > 
        
                               <ReceiptImage {...propsObj} /> 
        
                           </PressableWithoutFocus> 
        
                       )} 
        
                   </ShowContextMenuContext.Consumer> 
        
               ); 
        
           } 
        
           return <ReceiptImage {...propsObj} />;

We need to update the enablePreviewModal prop to enablePreviewModal={!readonly}.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 467 in 08bb00b

enablePreviewModal

What alternative solutions did you explore? (Optional)

We can introduce a new prop interactive in ReportActionItemImage and pass it to PressableWithoutFocus interactive prop. The default value will be true
From MoneyRequestView we can pass !readonly to interactive prop of ReportActionItemImage.

Result

receipt_image_interactive_dupe_detection.mp4

Alternative

We can check the last route and if it is SCREENS.TRANSACTION_DUPLICATE.REVIEW, we will set the canEditReceipt to false. Similar approach is used here to do tasks according to the previous route. I still prefer the main solution since all other fields are also disabled and receipt should also behave the same way.

    const isLastRouteDuplicateReview = (navigationRef.getRootState()?.routes?.at(-2)?.params?.params?.screen ?? '') === SCREENS.TRANSACTION_DUPLICATE.REVIEW;
    const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT) && !isLastRouteDuplicateReview;
    
    // If we want to hide the three dot icon, we can modify `allowDownload` prop.
    allowDownload={!isEReceipt && !isLastRouteDuplicateReview}

App/src/pages/TransactionReceiptPage.tsx

Line 36 in f7e265a

    
           const canEditReceipt = ReportUtils.canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.RECEIPT);

App/src/pages/TransactionReceiptPage.tsx

Line 62 in f7e265a

allowDownload={!isEReceipt}

Result Alternative

Monosnap.screencast.2024-07-31.18-11-07.mp4

Job added to Upwork: https://www.upwork.com/jobs/~01e50d0c63fac1b4f3

@anmurali

@anmurali This is ready for payment.

Regression Test Proposal:

Submit 2 duplicated expenses with receipts
Go to the thread transaction report
Press Review duplicates
Proceed to confirmation page
Press receipt preview
Press 3-dot menu
Verify "Replace" and "Delete receipt" options are not shown

Do we agree 👍 or 👎

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#40153

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I don't think we can blame the PR for creating this issue as it is more of a feature-request than a bug.

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#46373 (comment)

@anmurali

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Huh... This is 4 days overdue. Who can take care of this?

@anmurali

@anmurali all you on this one!

@anmurali

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Still overdue 6 days?! Let's take care of this!

@anmurali

@anmurali, @sobitneupane, @stitesExpensify, @gijoe0295 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@sobitneupane

Payment Summary

@sobitneupane $250 approved, request via New Dot
@gijoe0295 $250 approved, paid via Upwork

@sobitneupane

$250 approved for @sobitneupane

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal Update

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Alternative

Result Alternative

46 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<MoneyRequestView
	report={report}
	shouldShowAnimatedBackground={false}
	readonly

	<ReportActionItemImage
	thumbnail={receiptURIs?.thumbnail}
	fileExtension={receiptURIs?.fileExtension}
	isThumbnail={receiptURIs?.isThumbnail}
	image={receiptURIs?.image}
	isLocalFile={receiptURIs?.isLocalFile}
	filename={receiptURIs?.filename}
	transaction={transaction}
	enablePreviewModal
	/>

	if (enablePreviewModal) {
	return (
	<ShowContextMenuContext.Consumer>
	{({report, transactionThreadReport}) => (
	<PressableWithoutFocus
	style={[styles.w100, styles.h100, styles.noOutline as ViewStyle]}
	onPress={() =>
	Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(transactionThreadReport?.reportID ?? report?.reportID ?? '-1', transaction?.transactionID ?? '-1'))
	}
	accessibilityLabel={translate('accessibilityHints.viewAttachment')}
	accessibilityRole={CONST.ROLE.BUTTON}
	>
	<ReceiptImage {...propsObj} />
	</PressableWithoutFocus>
	)}
	</ShowContextMenuContext.Consumer>
	);
	}

	return <ReceiptImage {...propsObj} />;

[HOLD for payment 2024-08-29] [$250] Dupe detect-Removing receipt on confirmation page also removes receipt from the actual expense #46373

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 27, 2024

lanitochka17 commented on Jul 27, 2024

lanitochka17 commented on Jul 27, 2024

gijoe0295 commented on Jul 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

gijoe0295 commented on Jul 28, 2024

Proposal Update

Krishna2323 commented on Jul 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Alternative

Result Alternative

melvin-bot commented on Jul 30, 2024

46 remaining items

gijoe0295 commented on Aug 29, 2024

sobitneupane commented on Sep 2, 2024

sobitneupane commented on Sep 2, 2024

melvin-bot commented on Sep 2, 2024

stitesExpensify commented on Sep 3, 2024

melvin-bot commented on Sep 4, 2024

melvin-bot commented on Sep 6, 2024

anmurali commented on Sep 9, 2024

Payment Summary

garrettmknight commented on Oct 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions