Repository navigation
[Hold of Payment Sept 7] User can invite chronos@, receipts@ and concierge@ in Workspaces #4646
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open newDot.
- Go to any Workspace.
- Try to invite chronos@, receipts@, and concierge@.
Expected Result:
Users can not invite chronos@, receipts@, and concierge@ to the workspace.
Actual Result:
chronos@, receipts@, and concierge@ are added as workspace Users.
Workaround:
Don't invite chronos@, receipts@, and concierge@ to your workspace.
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.0.85.x
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Proposal
- we have to exclude these system users while checking for input text validity for email and phone.
- we have these emails available in the CONST.js
Line 260 in 8b10c1c
- We add the receipts@ to this const and create a general utility method that checks that is an entered email a system user
isSystemUser. - We can use that here and discard the logins with a Growl saying something
System users are not allowed to be invited.
Activity
MelvinBot commentedon Aug 13, 2021
Triggered auto assignment to @trjExpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.trjExpensify commentedon Aug 16, 2021
Ah yes, we should definitely not allow this. We hide these users in the request money/split bills flows already. Handing over to engineering triage.
CC: @MitchExpensify & @kevinksullivan as this is related to N6.
MelvinBot commentedon Aug 16, 2021
Triggered auto assignment to @roryabraham (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.roryabraham commentedon Aug 17, 2021
@parasharrajat Can work on the front-end piece, but I think maybe we should duplicate this validation in the back-end. So this issue can be mixed internal and external. External in NewDot and internal in the API.
MelvinBot commentedon Aug 17, 2021
Triggered auto assignment to @stephanieelliott (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.21 remaining items
roryabraham commentedon Aug 24, 2021
Linked PR is now on HOLD for #4649 to be merged.
Christinadobrzyn commentedon Sep 1, 2021
Looks like PR #4781 (comment) is merged! Holding for payment in 7 days.
[-]User can invite chronos@, receipts@ and concierge@ in Workspaces[/-][+][Hold of Payment Sept 7] User can invite chronos@, receipts@ and concierge@ in Workspaces[/+]Santhosh-Sellavel commentedon Sep 7, 2021
As @Julesssss suggested bring up the question here!
I see changes I proposed in #4668 were taken and implemented along with this issue.
Will I get a bonus?
Please clarify @Christinadobrzyn Thanks!
parasharrajat commentedon Sep 7, 2021
I fixed 4 things in one. Should I also ask for bonus for extra issues? :) :--) But I don't want it as I fixed all issues that I found with inviting logic (this issue is linked with inviting part).
Julesssss commentedon Sep 7, 2021
@Santhosh-Sellavel just to clarify, I didn't confirm that the changes you suggested were taken and implemented. I said that you have a good argument for it and that you should bring it up in this issue.
Santhosh-Sellavel commentedon Sep 7, 2021
@Julesssss Updated my comment accordingly, Since you pointed this issue out, I thought you were aware that changes I proposed were done in this issue. Sorry for the misunderstanding!
Christinadobrzyn commentedon Sep 8, 2021
PR is merged for over 7 days - paid @parasharrajat for the job. Thanks! 🎉
Upwork contract is closed. Closing this issue.
Christinadobrzyn commentedon Sep 8, 2021
@Santhosh-Sellavel - thanks for raising the question about getting paid for this related issue. I will reach out to my team about this and follow up with you in issue #4668.