Repository navigation
Expensify Card - Empty state card is top centered instead of middle centered #46488
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Launch New Expensify app.
- Go to workspace settings.
- Go to Expensify Card.
Expected Result:
The empty state card will be middle centered (production behavior).
Actual Result:
Empty state card is top centered instead of middle centered.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6557060_1722324180554.ScreenRecording_07-30-2024_15-18-34_1.mp4
Activity
melvin-bot commentedon Jul 30, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jul 30, 2024
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 30, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Jul 30, 2024
We think this issue might be related to the #collect project.
nyomanjyotisa commentedon Jul 30, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Coming from #45996
Justify content set to
flex-startifisSmallScreenWidthtrueApp/src/pages/workspace/expensifyCard/EmptyCardView.tsx
Line 41 in 75be218
What changes do you think we should make in order to solve the problem?
We should change that to the following to make it center like on production and with the new button margin
What alternative solutions did you explore? (Optional)
allgandalf commentedon Jul 30, 2024
@DylanDylann @koko57 Was this intentional ?
18 remaining items
DylanDylann commentedon Aug 5, 2024
@anmurali Please assign me and @koko57 to this issue
koko57 commentedon Aug 6, 2024
@DylanDylann PR ready for review #46860
melvin-bot commentedon Aug 29, 2024
This issue has not been updated in over 15 days. @youssef-lr, @anmurali, @koko57, @mountiny, @DylanDylann eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
koko57 commentedon Aug 30, 2024
@mountiny I think we can close it
mountiny commentedon Sep 2, 2024
Thanks!