Repository navigation
[Due for payment 2025-04-02] [Performance][Search] Opening search for the first time on a big account is causing the app to hang massively #46590
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
In a customers meeting the customer was trying to open the search for the first time in NewDot. It caused the app to hang up, and it was a very bad user experience (see the recording):
Screen.Recording.2024-07-31.at.16.25.28.mov
What is the impact of this on end-users?
User perception of the app is very bad, as it's super laggy, basically not usable (the browser even warns that the app is hanging).
List any benchmarks that show the severity of the issue
The customer shared a profile trace with us:
Firefox 2024-07-25 10.42 profile.json.gz
(note: the trace also contains other test cases as well)
The customer had ~15k reports loaded in onyx when these tests were conducted, although in focus mode only 6 chats were displayed.
Proposed solution (if any)
None yet, I will go through the profile and see what can be optimised, what exactly caused those lags.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
not available yet
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Version Number: v9.0.11-5
Reproducible in staging?: not tested
Reproducible in production?: yes
Email or phone of affected tester (no customers): customer
Logs: See performance file
Notes/Photos/Videos: See attached video
Expensify/Expensify Issue URL: n/a
Issue reported by: @hannojg
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721919928992729
Metadata
Metadata
Type
Projects
- Status
Activity
melvin-bot commentedon Jul 31, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
hannojg commentedon Jul 31, 2024
cc @sakluger (feel free to assign me as I (or someone from my team) will work on this ticket!)
marcaaron commentedon Aug 2, 2024
Curious what is happening with this especially to see if it is related to large numbers of reports (seems likely as there are 15k reports). Gonna assign myself in case @hannojg needs any assistance.
sakluger commentedon Aug 5, 2024
No updates
sakluger commentedon Aug 8, 2024
No update
106 remaining items
[-][Performance][Search] Opening search for the first time on a big account is causing the app to hang massively[/-][+][Due for payment 2025-04-02] [Performance][Search] Opening search for the first time on a big account is causing the app to hang massively[/+]melvin-bot commentedon Mar 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
sakluger commentedon Apr 2, 2025
Awesome to see this one completed! No payment required through Upwork or NewDot payments.
Ollyws commentedon Apr 24, 2025
Hey, seems I never got paid for my review of #55348, could we get that sorted? Thanks! @sakluger
mallenexpensify commentedon Apr 29, 2025
Contributor+: @Ollyws due $250 via NewDot
Apologies!
Ollyws commentedon May 9, 2025
Requested in ND.
garrettmknight commentedon May 20, 2025
$250 approved for @Ollyws