Skip to content

[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] [Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat #46614

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new account.
  3. Click Chat and split expenses with friends.
  4. Must repeat Step 2 and 3 until the onboarding tasks are created in Concierge chat (user ID that ends with even number) and not Expensify.

Expected Result:

Onboarding tasks will be created in Concierge chat without issue.

Actual Result:

Error shows up when onboarding tasks are created in Concierge chat.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6558581_1722458556508.onboarding.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 31, 2024
  2. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jul 31, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  6. Beamanator commented on Jul 31, 2024

    @Beamanator
    Contributor

    I believe Guided Setup Stage 2 is #wave-collect

    @francoisl you're leading this? https://github.com/Expensify/Expensify/issues/356685 any ideas which PR may have caused this? It looks like a backend thing but could be caused by front-end params maybe

  7. 14 remaining items

  8. Beamanator commented on Aug 1, 2024

    @Beamanator
    Contributor

    Seems to be working well on staging! Thanks for the help @francoisl !

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 2, 2024
  10. changed the title [-][Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat[/-] [+][HOLD for payment 2024-08-09] [Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat[/+] on Aug 2, 2024
  11. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

  12. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
    • [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Beamanator] Determine if we should create a regression test for this bug.
    • [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. changed the title [-][HOLD for payment 2024-08-09] [Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat[/-] [+][HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] [Guided Setup Stage 2] - Error shows up when onboarding tasks are created in Concierge chat[/+] on Aug 6, 2024
  14. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-13. 🎊

  15. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
    • [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Beamanator] Determine if we should create a regression test for this bug.
    • [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions