[HOLD for payment 2024-08-13] [$250] iOS - Workspace - Dropdown button is not disabled when no selection is made

@lschurr

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #45732
Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Launch New Expensify app.
Go to workspace settings > Members.
Invite a few members if there is no members.
Long press on any member.
Tap Select.
Unselect the member.
Tap on the dropdown button.

Expected Result:

Dropdown button should be disabled when no selection is made (same behavior on Search).

Actual Result:

Dropdown button is not disabled when no selection is made. Remove members option is present when no member is selected.

This issue happens for other pages like Categories, Taxes, Tags etc

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6558585_1722458560418.select.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01646ead25f1035d7c
Upwork Job ID: 1818788590509081901
Last Price Increase: 2024-07-31

Issue Owner

Current Issue Owner: @lschurr

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@roryabraham

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dropdown button is not disabled when no selection is made

What is the root cause of that problem?

We don't disable the button when no members are selected:

What changes do you think we should make in order to solve the problem?

We will add a isDisabled prop checking selectedEmployees.length here:

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 510 to 515 in 00a45ac

    
           <ButtonWithDropdownMenu<WorkspaceMemberBulkActionType> 
        
               shouldAlwaysShowDropdownMenu 
        
               pressOnEnter 
        
               customText={translate('workspace.common.selected', {selectedNumber: selectedEmployees.length})} 
        
               buttonSize={CONST.DROPDOWN_BUTTON_SIZE.MEDIUM} 
        
               onPress={() => null}

isDisabled={!selectedEmployees.length}

Additionally:

We will also not add the Remove Members option here if selectedEmployees.length is zero

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 467 to 472 in 00a45ac

    
           { 
        
               text: translate('workspace.people.removeMembersTitle'), 
        
               value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.REMOVE, 
        
               icon: Expensicons.RemoveMembers, 
        
               onSelected: askForConfirmationToRemove, 
        
           },

We will do the same for WorkspaceTagsPage, WorkspaceCategoriesPage, PolicyDistanceRatesPage, WorkspaceReportFieldsPage, WorkspaceTaxesPage which use the same pattern of selection and have the issue present.

@jayeshmangwani

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Dropdown button is not disabled when no selection is made #46679

If no regressions arise, payment will be issued on 2024-08-13. 🎊

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment through NewDot Manual Requests
@neonbhai requires payment (Needs manual offer from BZ)

@jayeshmangwani

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jayeshmangwani

Payment Summary

Upwork Job

Reviewer: @jayeshmangwani owed $250 via NewDot
Contributor: @neonbhai $250 (Paid in Upwork)

BugZero Checklist (@lschurr)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1818788590509081901/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@neonbhai

@neonbhai - Offer sent in Upwork :)

@lschurr

@lschurr Thank you, accepted!

All set. Payment summary is correct.

@jayeshmangwani

[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Mobile Selection Mode #46096
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Mobile Selection Mode #46096 (comment)
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@jayeshmangwani] Determine if we should create a regression test for this bug. NO, IMO, there's no need to create a test for this since we missed including it as part of the new feature.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Requested on ND as per #46619 (comment)

@jayeshmangwani

$250 approved for @jayeshmangwani

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-13] [$250] iOS - Workspace - Dropdown button is not disabled when no selection is made #46619

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Additionally:

25 remaining items

Payment Summary

BugZero Checklist (@lschurr)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ButtonWithDropdownMenu<WorkspaceMemberBulkActionType>
	shouldAlwaysShowDropdownMenu
	pressOnEnter
	customText={translate('workspace.common.selected', {selectedNumber: selectedEmployees.length})}
	buttonSize={CONST.DROPDOWN_BUTTON_SIZE.MEDIUM}
	onPress={() => null}

	{
	text: translate('workspace.people.removeMembersTitle'),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.REMOVE,
	icon: Expensicons.RemoveMembers,
	onSelected: askForConfirmationToRemove,
	},

[HOLD for payment 2024-08-13] [$250] iOS - Workspace - Dropdown button is not disabled when no selection is made #46619

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

github-actions commented on Jul 31, 2024

neonbhai commented on Jul 31, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Additionally:

25 remaining items

melvin-bot commented on Aug 6, 2024

melvin-bot commented on Aug 6, 2024

melvin-bot commented on Aug 13, 2024

Payment Summary

BugZero Checklist (@lschurr)

lschurr commented on Aug 13, 2024

neonbhai commented on Aug 13, 2024

lschurr commented on Aug 13, 2024

jayeshmangwani commented on Aug 13, 2024

jayeshmangwani commented on Aug 15, 2024

JmillsExpensify commented on Aug 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions