[$250] Workspace - "Remove members" and "Make admin" options are present for owner #46620
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating #45732
Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: unable to check new feature
Issue reported by: applause internal team
Action Performed:
- Launch New Expensify app.
- Go to workspace settings > Members.
- Long press on the owner.
- Tap Select.
- Tap on the dropdown.
Expected Result:
Owner should not be able to be selected (production behavior).
Actual Result:
Owner can be selected and there are "Remove members" and "Make members" options which are not applicable to the owner.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0110a7f901ae8b6a28
- Upwork Job ID: 1818787780851878074
- Last Price Increase: 2024-07-31
- Automatic offers:
- neonbhai | Contributor | 103438189
Activity
melvin-bot commentedon Jul 31, 2024
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 31, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jul 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Jul 31, 2024
We think that this bug might be related to #wave-collect - Release 1
44 remaining items
melvin-bot commentedon Sep 20, 2024
@cead22, @bfitzexpensify, @neonbhai, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
cead22 commentedon Sep 23, 2024
Bump @neonbhai @bfitzexpensify
bfitzexpensify commentedon Sep 24, 2024
Back from OOO, handling this now
Payment summary:
@neonbhai to be paid $250 for contributor work - offer sent via Upwork
@getusha to be paid $250 for C+ work - via manual request
@getusha can you complete the checklist in #46620 (comment)? Thanks!
melvin-bot commentedon Sep 27, 2024
@cead22, @bfitzexpensify, @neonbhai, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
getusha commentedon Sep 29, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@getusha] The PR that introduced the bug has been identified. Link to the PR: #46096
[@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #46096 (comment)
[@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@getusha] Determine if we should create a regression test for this bug. No. IMO it's not related to an important flow and isn't impactful
[@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
bfitzexpensify commentedon Sep 30, 2024
Thanks! Let's close this out
garrettmknight commentedon Oct 2, 2024
$250 approved for @getusha