Skip to content

Taxes - Tax code content is not shown until the workspace is upgraded to Control #46624

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #45866
Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a Collect workspace.
  3. Go to workspace settings > Taxes.
  4. Click on any tax.
  5. Note that Tax code is empty.
  6. Click on the Tax code.
  7. Click Upgrade.
  8. Note that Tax code content is only shown after upgrading to Control.

Expected Result:

in Step 5, Tax code content will be shown even if the workspace plan is Collect (production behavior).

Actual Result:

in Step 5, Tax code content is not shown until the workspace is upgraded to Control (Step 8).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6558669_1722464787662.20240801_062231.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 31, 2024
  2. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. m-natarajan commented on Jul 31, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-control

  4. neonbhai commented on Jul 31, 2024

    @neonbhai
    Contributor

    This should be expected as noted in #45866 (comment)

    we are going to hide the taxID for non control policy because it makes it look more like its behind a paywall

    cc: @rushatgabhane

  5. rushatgabhane commented on Jul 31, 2024

    @rushatgabhane
    Member

    this is not a bug. it is expected

  6. rushatgabhane commented on Jul 31, 2024

    @rushatgabhane
    Member

    thanks for tagging @neonbhai

  7. brunovjk commented on Aug 2, 2024

    @brunovjk
    Contributor

    Should we create a regre test here including this scenario?

  8. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    @strepanier03 Huh... This is 4 days overdue. Who can take care of this?

  9. strepanier03 commented on Aug 6, 2024

    @strepanier03
    Contributor

    @brunovjk - I agree we should create the reg test for this. Gonna close out this GH but feel free to comment in that other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions