Repository navigation
Android - Room - Enter key saves the room description instead of entering the next line #46644
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
- Device keyboard must be Samsung keyboard.
- This issue is not reproducible with Gboard.
- Launch New Expensify app.
- Go to any room.
- Tap on the room header.
- Tap on Room description.
- Enter some text.
- Tap Enter on the keyboard.
Expected Result:
Enter key will enter the next line (production behavior with Samsung keyboard).
Actual Result:
Enter key saves the room description instead of entering the next line.
This issue is only reproducible on Samsung keyboard and not Gboard.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Aug 1, 2024
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 1, 2024
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Aug 1, 2024
We think this issue might be related to the #vip-vsb
izarutskaya commentedon Aug 1, 2024
Production
Screen_Recording_20240801_121709_New.Expensify.mp4
huult commentedon Aug 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Enter key saves the room description instead of entering the next line
What is the root cause of that problem?
Missing
disablePressOnEnterinFormProviderto disable saving on Enter key press.What changes do you think we should make in order to solve the problem?
Add
disablePressOnEnterinFormProviderto disable saving on Enter key press.// src/pages/RoomDescriptionPage.tsx#L76 <FormProvider style={[styles.flexGrow1, styles.ph5]} formID={ONYXKEYS.FORMS.REPORT_DESCRIPTION_FORM} onSubmit={submitForm} submitButtonText={translate('common.save')} enabledWhenOffline + disablePressOnEnter >Details
POCScreen_Recording_20240801_132510_New.Expensify.Dev.mp4
5 remaining items
rayane-d commentedon Aug 1, 2024
@nyomanjyotisa Could you please take a look at this issue?
I think we should enable
disablePressOnEnterwhen one of the form inputs hasshouldSubmitFormasfalseand it's focusedApp/src/components/Form/InputWrapper.tsx
Line 57 in 1a93406
MonilBhavsar commentedon Aug 1, 2024
Thank you for looking. If you don't mind, I'll assign you to this issue as a C+
nyomanjyotisa commentedon Aug 1, 2024
Sure, will check and create a follow up PR today
MonilBhavsar commentedon Aug 2, 2024
Thank you @nyomanjyotisa! I have assigned you to the issue
rayane-d commentedon Aug 5, 2024
Any update here @nyomanjyotisa ? 😃
nyomanjyotisa commentedon Aug 6, 2024
@rayane-djouah PR ready for review
rayane-d commentedon Aug 19, 2024
PR on staging
rayane-d commentedon Aug 20, 2024
@MonilBhavsar We can close this one. No payment is due.
MonilBhavsar commentedon Aug 20, 2024
Sounds good, thanks all for the help!