Skip to content

[HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] Search - Unable to exit selection mode via app back button while the expense is selected #46650

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.15-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Launch New Expensify app.
  2. Go to any chat.
  3. Submit an expense.
  4. Go to Search.
  5. Long press on the expense.
  6. Tap Select.
  7. Tap on the back button while the expense is selected.

Expected Result:

Selection mode will exit.

Actual Result:

App is unable to exit the selection mode when tapping on back button while the expense is selected.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6558883_1722491266365.ScreenRecording_08-01-2024_13-44-41_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 1, 2024
  2. melvin-bot commented on Aug 1, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 1, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Aug 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Aug 1, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  6. Kicu commented on Aug 1, 2024

    @Kicu
    Contributor

    @filip-solecki do you mind taking a look here?

  7. pecanoro commented on Aug 1, 2024

    @pecanoro
    Contributor

    I was able to reproduce it, it takes a little bit for me to go back to the selection page but yeah, it keeps getting back without being able to cancel it.

  8. 14 remaining items

  9. changed the title [-]Search - Unable to exit selection mode via app back button while the expense is selected[/-] [+][HOLD for payment 2024-08-09] Search - Unable to exit selection mode via app back button while the expense is selected[/+] on Aug 2, 2024
  10. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment (Needs manual offer from BZ)
  11. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. changed the title [-][HOLD for payment 2024-08-09] Search - Unable to exit selection mode via app back button while the expense is selected[/-] [+][HOLD for payment 2024-08-13] [HOLD for payment 2024-08-09] Search - Unable to exit selection mode via app back button while the expense is selected[/+] on Aug 6, 2024
  13. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.16-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Aug 6, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions