[HOLD for payment] [$250] Admins room members shows 2 members but members list only has one person

@puneetlath

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.15-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722451867724679

Action Performed:

Sign up for account
Choose "manage my team"
Click on the "meet your setup specialist" task
Click on the "admins room" link

Expected Result:

Both admin and chat specialist displayed in admin room

Actual Result:

Only admin is displayed in member list but the member count is displayed as 2

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Recording.403.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0158f19a1453ec7c77
Upwork Job ID: 1819232195007431581
Last Price Increase: 2024-08-02
Automatic offers:

dominictb | Contributor | 103414279

Issue Owner

Current Issue Owner: @allroundexperts

@VictoriaExpensify

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only admin is displayed in member list but the member count is displayed as 2

What is the root cause of that problem?

We do not filter out the accountID that is not available in personalDetails data:

App/src/pages/ReportDetailsPage.tsx

Lines 146 to 149 in 157afbf

    
           const activeChatMembers = participants.flatMap((accountID) => { 
        
               const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString()); 
        
               return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : []; 
        
           });

like we did in

App/src/pages/ReportParticipantsPage.tsx

Lines 71 to 73 in 157afbf

    
           const details = personalDetails?.[accountID]; 
        
           if (!details) { 
        
               Log.hmmm(`[ReportParticipantsPage] no personal details found for Group chat member with accountID: ${accountID}`);

What changes do you think we should make in order to solve the problem?

We should check if the accountID is available in personalDetails data or not. If not, remove from activeChatMembers

App/src/pages/ReportDetailsPage.tsx

Lines 146 to 149 in 157afbf

    
           const activeChatMembers = participants.flatMap((accountID) => { 
        
               const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString()); 
        
               return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : []; 
        
           });

We also can filter out in

App/src/pages/ReportDetailsPage.tsx

Lines 139 to 142 in 157afbf

    
           const participants = useMemo(() => { 
        
               const shouldExcludeHiddenParticipants = !isGroupChat && !isSystemChat; 
        
               return ReportUtils.getParticipantsAccountIDsForDisplay(report, shouldExcludeHiddenParticipants); 
        
           }, [report, isGroupChat, isSystemChat]);

What alternative solutions did you explore? (Optional)

true

Proposal updated

true

Recreated issue:

Agree we should fix this.

Job added to Upwork: https://www.upwork.com/jobs/~0158f19a1453ec7c77

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@Gonals

This issue has not been updated in over 15 days. @Gonals, @allroundexperts, @VictoriaExpensify, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts ] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexpert ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts ] Determine if we should create a regression test for this bug.
[@allroundexperts ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@VictoriaExpensify Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dominictb

Payment summary:
Contributor: @dominictb paid $250 via Upwork

@allroundexperts I will make your payment once the checklist is complet

@VictoriaExpensify

@VictoriaExpensify Can you add HOLD for payment to the title as well?

Checklist

[Fix]: Number of announce room members does not update when remove workspace members due to pendingAction #39796
https://github.com/Expensify/App/pull/39796/files#r1807946690
N/A
A regression test would be good.

Regression test

Sign up for a new account
In the onboarding modal that appears, choose "manage my team"
Click on the "meet your setup specialist" task
Click on the opened admin room title
Select members from the RHN

Verify that the member count equals to the number of users being shown in the list.

Do we 👍 or 👎 ?

@VictoriaExpensify

@VictoriaExpensify can you also update the payment summary with an amount for @allroundexperts

@dominictb

Updated Payment summary:
Contributor: @dominictb paid $250 via Upwork
Contributor+: @allroundexperts owed $250 via NewDot

Raised a request to add the regression test to TestRail - https://github.com/Expensify/Expensify/issues/440290

So I think we're all done here. Thanks!

@allroundexperts

$250 approved for @allroundexperts

Navigation Menu

Repository navigation

[HOLD for payment] [$250] Admins room members shows 2 members but members list only has one person #46670

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal updated

10 remaining items

Checklist

Regression test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const activeChatMembers = participants.flatMap((accountID) => {
	const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
	return !pendingMember \|\| pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
	});

	const details = personalDetails?.[accountID];
	if (!details) {
	Log.hmmm(`[ReportParticipantsPage] no personal details found for Group chat member with accountID: ${accountID}`);

	const participants = useMemo(() => {
	const shouldExcludeHiddenParticipants = !isGroupChat && !isSystemChat;
	return ReportUtils.getParticipantsAccountIDsForDisplay(report, shouldExcludeHiddenParticipants);
	}, [report, isGroupChat, isSystemChat]);

[HOLD for payment] [$250] Admins room members shows 2 members but members list only has one person #46670

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 1, 2024

dominictb commented on Aug 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

github-actions commented on Aug 2, 2024

dominictb commented on Aug 2, 2024

Proposal updated

github-actions commented on Aug 2, 2024

VictoriaExpensify commented on Aug 2, 2024

melvin-bot commented on Aug 2, 2024

melvin-bot commented on Aug 2, 2024

10 remaining items

melvin-bot commented on Aug 30, 2024

VictoriaExpensify commented on Sep 11, 2024

VictoriaExpensify commented on Sep 11, 2024

dominictb commented on Sep 30, 2024

allroundexperts commented on Oct 20, 2024

Checklist

Regression test

JmillsExpensify commented on Oct 30, 2024

VictoriaExpensify commented on Oct 30, 2024

VictoriaExpensify commented on Oct 30, 2024

JmillsExpensify commented on Oct 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions