Repository navigation
Count is always shown as 1 new message when there are multiple unread messages in the new MarkerBadge #4669
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any conversation in newDot.
- Scroll back in the history to see the new Markerbadge when new messages are received.
- Send a new message from another device to the correct chat from the other user.
- See that the new Marker badge is shown.
- Now don't yet interact with the app or marker yet.
- Send another message from the other device.
- Observe that count is still 1.
Expected Result:
The count should increase to see the correct number.
Actual Result:
The count is always one.
Workaround:
None.
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.0.85.-5
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
issue-marker.mp4
Expensify/Expensify Issue URL:
Activity
MelvinBot commentedon Aug 14, 2021
Triggered auto assignment to @mallenexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.parasharrajat commentedon Aug 14, 2021
Explanation:
this.props.report.unreadActionCountin the Markerbadge.this.props.report.unreadActionCountreset code is executedApp/src/pages/home/report/ReportActionsView.js
Line 199 in 8b10c1c
Proposal after Triage is done...
mallenexpensify commentedon Aug 16, 2021
I'm not seeing this
I tried to message myself between desktop and web on two different accounts, with web being on staging.
@parasharrajat , any idea why I'm not seeing the notification?
parasharrajat commentedon Aug 16, 2021
Sorry @mallenexpensify, this is yet to be deployed to staging or PROD #4603
mallenexpensify commentedon Aug 16, 2021
Should we wait for it to hit one or both before attempting a fix/update?
Or.. put another way... If I'm unable to test, then it's hard for me to recommend we should make this update.
parasharrajat commentedon Aug 16, 2021
Yes. I am holding it till #4603. Created the issue so that it can be fixed quickly.
parasharrajat commentedon Aug 17, 2021
@mallenexpensify the PR just hit Staging and the issue is now active.
mallenexpensify commentedon Aug 18, 2021
Took a min (aka, I needed to read your steps, ha) but I was able to reproduce on web, staging.
At one point I did actually see the number rise to 3 but it most commonly was returning 1.
Gonna move along to an engineer to ensure this can be an external issue :)
MelvinBot commentedon Aug 18, 2021
Triggered auto assignment to @roryabraham (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.28 remaining items
roryabraham commentedon Aug 26, 2021
PR was deployed to staging earlier today
roryabraham commentedon Aug 26, 2021
Oops,
Awaiting Paymentwas premature, should be added when the PR is deployed to prod.alex-mechler commentedon Aug 26, 2021
The current fix added a deploy blocker here: #4863
roryabraham commentedon Sep 3, 2021
This was deployed to production w/ regressions fixed in v1.0.88-2 – Should pay on Monday 9/6 (Labor Day) assuming no other regressions are found 🙂
parasharrajat commentedon Sep 8, 2021
@dylanexpensify Any update for me on the Upwork job?
parasharrajat commentedon Sep 13, 2021
@dylanexpensify hmm. 🍷
dylanexpensify commentedon Sep 13, 2021
Hi @parasharrajat! Sorry for the delay! I was OOO - will work on this today! @roryabraham no further regressions, correct?
dylanexpensify commentedon Sep 13, 2021
@parasharrajat payment has been sent! Job closed out. Great work team!