Repository navigation
[PAID] [Search v2.1] - Sorting on Drafts and Finished does not work at all #46720
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+khcategory15@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
- Account has lots of expenses in Drafts and Finished section (Search)
- Go to staging.new.expensify.com
- Go to Search
- Go to Drafts
- Apply Date, Merchant and Amount sorting
- Repeat Step 3 and 4 with Finished section
Expected Result:
The expenses will be sorted accordingly
Actual Result:
The sorting on Drafts and Finished does not work at all
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Aug 2, 2024
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Aug 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
dangrous commentedon Aug 2, 2024
Seems to happen on production build on local, so maybe backend or a previous regression that wasn't caught. Asking the folks working on search to have a look
rayane-d commentedon Aug 2, 2024
I believe this issue is related to a backend bug. @luacmartins recently worked on a backend change (#46481 (comment)) to address this bug, which could be causing the current problem. However, @luacmartins is currently out of the office. Can we find someone internally to handle this?
dangrous commentedon Aug 2, 2024
I'm continuing to look into it but haven't found a fix yet. @iwiznia it looks like you worked on some of the syntax - any ideas? I've confirmed that the asc/desc exists correctly as ORDER BY in the query that's run here (e.g.
ORDER BY toUser asc LIMIT 51) but the data returned, at least by this point is no different, no matter the sort order that was sent. So, need to figure out why that's not changing anything...The search already gets wacky results on prod, so although clicking the columns does CHANGE the sort, it's still wrong, so I'm not sure this is enough of an issue to block deploy... but open to other opinions
dangrous commentedon Aug 2, 2024
Running SQL queries directly via command line DOES result in differently ordered results... so the issue has to be in
Search::buildTransactionResponse()35 remaining items
sonialiap commentedon Aug 16, 2024
Payment summary:
melvin-bot commentedon Aug 16, 2024
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.sonialiap commentedon Aug 16, 2024
@strepanier03 I'm OOO Aug 19-30, adding leave buddy.
Status: if no regressions popup, please complete payment on the 19th. Payment summary
ikevin127 commentedon Aug 19, 2024
strepanier03 commentedon Aug 19, 2024
Paid. closing.
[-][HOLD for payment 2024-08-19] [Search v2.1] - Sorting on Drafts and Finished does not work at all[/-][+][PAID] [Search v2.1] - Sorting on Drafts and Finished does not work at all[/+]