You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-29] [$250] NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials #46768
Please re-state the problem that we are trying to solve in this issue.
Sync error isn't displayed when connecting to NetSuite with invalid credentials
What is the root cause of that problem?
We don't return true on hasSynchronizationError function if the net suite connection verified value is false, since verified is an indicator of whether the sync connection has been successful
changed the title [-]NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials[/-][+][$250] NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials[/+]on Aug 5, 2024
[@brunovjk] The PR that introduced the bug has been identified. Link to the PR: Not a regression, but an exception for NetSuite in error checking logic: commit
[@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g., updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion needed as this was not a systemic issue but a missed check for verified === false.
[@brunovjk] Determine if we should create a regression test for this bug. Yes
[@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Aug 3, 2024
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Aug 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Sync error isn't displayed when connecting to NetSuite with invalid credentials
What is the root cause of that problem?
We don't return
trueonhasSynchronizationErrorfunction if the net suite connectionverifiedvalue is false, sinceverifiedis an indicator of whether the sync connection has been successfulApp/src/libs/actions/connections/index.ts
Lines 366 to 372 in d0ecede
App/src/types/onyx/Policy.ts
Lines 971 to 972 in d0ecede
What changes do you think we should make in order to solve the problem?
Update this code to the following to return
trueif the net suite connectionverifiedvalue is falseRESULT
New-Expensify.26.mp4
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Aug 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01ceab16370193c3b8
[-]NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials[/-][+][$250] NetSuite - Sync error isn't displayed when connecting to NetSuite with invalid credentials[/+]melvin-bot commentedon Aug 5, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (
External)sakluger commentedon Aug 5, 2024
Tagging @yuwenmemon, @mananjadhav, @shubham1206agra since you all worked on the design doc for this feature.
shubham1206agra commentedon Aug 6, 2024
@sakluger This looks like a BE issue.
30 remaining items
melvin-bot commentedon Aug 24, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.brunovjk commentedon Aug 26, 2024
verified === false.Regression Test Proposal
melvin-bot commentedon Aug 29, 2024
Payment Summary
Upwork Job
BugZero Checklist (@VictoriaExpensify)
tgolen commentedon Aug 30, 2024
@VictoriaExpensify Can you please complete the checklist here to close this one out?
VictoriaExpensify commentedon Sep 2, 2024
Created an issue to add the regression test to TestRail - https://github.com/Expensify/Expensify/issues/425122
VictoriaExpensify commentedon Sep 2, 2024
Payment summary:
Contributor: @nyomanjyotisa paid $250 via Upwork Job
Contributor+: @brunovjk paid $250 via Upwork Job
Thanks for your work on this issue!