[HOLD for payment][$250] - LHN preview is missing distance rate name in distance rate removal system message

@allroundexperts

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4827991
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Workspace has some distance rates

Go to staging.new.expensify.com
Go to workspace settings > Distance rates
Delete a distance rate
Go to #admins room of the same workspace
Refresh the page

Expected Result:

The LHN preview will display the complete distance rate removal system message

Actual Result:

The LHN preview is missing the name of the removed distance rate in the system message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6564191_1723021787060.20240807_170549.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016424eee2de4a22ba
Upwork Job ID: 1821384517474279929
Last Price Increase: 2024-08-22
Automatic offers:

FitseTLT | Contributor | 103698148

Issue Owner

Current Issue Owner: @allroundexperts

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@kadiealexander

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-08-07 19:39:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN preview is missing distance rate name in distance rate removal system message

What is the root cause of that problem?

In getOptionData we are not dealing with POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE action types when getting alternateText for the LHN so it is falling back to setting it to the lastMessage of the report which misses distance rate name

App/src/libs/SidebarUtils.ts

Lines 431 to 432 in b806725

    
               result.alternateText = ReportUtils.formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? Localize.translateLocal('report.noActivityYet')); 
        
           }

What changes do you think we should make in order to solve the problem?

We need to set alternateText to the getReportActionMessageText of the lastAction if the last action type is POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE (FYI: That is how the report action is displayed in report action item) here

else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_CUSTOM_UNIT_RATE) {
            result.alternateText = ReportActionsUtils.getReportActionMessageText(lastAction) ?? '';
        }

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~016424eee2de4a22ba

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

I think this is pending payment. Can someone please take a look?

@kadiealexander

HI @kadiealexander would you mind checking that payment hasn't occurred yet? Thanks

@kadiealexander

@kadiealexander Payment overdue

@kadiealexander

@kadiealexander Can you pls issue payment here?? Thx

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@FitseTLT

Payouts due:

Contributor: $250 @FitseTLT (Offer link)
Reviewer: $250 @allroundexperts (via Manual Requests)

Upwork job is here.

@allroundexperts

$250 approved for @allroundexperts

@Julesssss

@Julesssss, @allroundexperts, @FitseTLT, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@allroundexperts

Hey @allroundexperts has this been paid out?

Yes, feel free to close.

Navigation Menu

Repository navigation

[HOLD for payment][$250] - LHN preview is missing distance rate name in distance rate removal system message #46967

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

29 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	result.alternateText = ReportUtils.formatReportLastMessageText(getWelcomeMessage(report, policy).messageText ?? Localize.translateLocal('report.noActivityYet'));
	}

[HOLD for payment][$250] - LHN preview is missing distance rate name in distance rate removal system message #46967

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 7, 2024

lanitochka17 commented on Aug 7, 2024

lanitochka17 commented on Aug 7, 2024

FitseTLT commented on Aug 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 8, 2024

melvin-bot commented on Aug 8, 2024

29 remaining items

allroundexperts commented on Sep 24, 2024

Julesssss commented on Sep 25, 2024

FitseTLT commented on Oct 3, 2024

FitseTLT commented on Oct 11, 2024

kadiealexander commented on Oct 13, 2024

kadiealexander commented on Oct 13, 2024

JmillsExpensify commented on Oct 14, 2024

melvin-bot commented on Oct 21, 2024

Julesssss commented on Oct 22, 2024

allroundexperts commented on Oct 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions