Repository navigation
[$250] Distance - App crashes when deleting a distance expense when there are two distance expenses #46980
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: .0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sarahhailu1268+dhsdfsdhgshg@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Log in to the staging app with a new account
- Create a new workspace
- Go to FAB > Submit Expense > Distance
- Enter start and finish waypoints > Submit it to the workspace
- Again go to FAB > Submit Expense > Distance
- Enter start and finish waypoints > Submit it to the workspace
- After the expenses are created go into the combined report and click on the first expense
- Click on the header > Delete expense > Confirm
Expected Result:
The app will not crash and the expense is successfully deleted
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6564505_1723039542006.2024-08-07_16_51_46.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0183948967c6155377
- Upwork Job ID: 1821209382283102288
- Last Price Increase: 2024-08-14
- Automatic offers:
- dominictb | Contributor | 103641053
Activity
melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Aug 7, 2024
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Aug 7, 2024
We think that this bug might be related to #wave-collect - Release 1
[-]Distance - App crashes when deleting a distance expense when there are two distance expenses[/-][+][$250] Distance - App crashes when deleting a distance expense when there are two distance expenses[/+]melvin-bot commentedon Aug 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0183948967c6155377
melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)etCoderDysto commentedon Aug 7, 2024
Edited by proposal-police: This proposal was edited at 2024-08-07 15:46:57 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when deleting a distance expense when there are two distance expenses
What is the root cause of that problem?
When deleting a distance request tags become undefined here
App/src/libs/OptionsListUtils.ts
Lines 1355 to 1356 in 0a33186
What changes do you think we should make in order to solve the problem?
We should use nullish coalescing operator to return empty array when tags is undefined in Ojbect.values
What alternative solutions did you explore? (Optional)
Result:
Screen.Recording.2024-08-07.at.7.00.55.in.the.evening.mp4
etCoderDysto commentedon Aug 7, 2024
Updated Proposal
40 remaining items
greg-schroeder commentedon Sep 19, 2024
Just awaiting deploy to prod!
greg-schroeder commentedon Sep 23, 2024
Deployed 9/19, regression period goes til 9/26
[-][$250] Distance - App crashes when deleting a distance expense when there are two distance expenses[/-][+][HOLD for payment 2024-09-26] [$250] Distance - App crashes when deleting a distance expense when there are two distance expenses[/+]greg-schroeder commentedon Sep 23, 2024
Payment summary:
Contributor: @dominictb - $250 - Will be paid via Upwork on 9/26
C+: @mollfpr - $250 - Can make a manual request via ND on 9/26
mollfpr commentedon Sep 26, 2024
I couldn't find the offending PR.
The regression step should be enough.
garrettmknight commentedon Sep 26, 2024
$250 approved for @mollfpr
[-][HOLD for payment 2024-09-26] [$250] Distance - App crashes when deleting a distance expense when there are two distance expenses[/-][+] [$250] Distance - App crashes when deleting a distance expense when there are two distance expenses[/+]