Skip to content

[HOLD for payment 2024-08-19] [$250] iOS - Distance split - App crashes after opening split distance expense receipt #47022

New issue
New issue
Closed
Closed
[HOLD for payment 2024-08-19] [$250] iOS - Distance split - App crashes after opening split distance expense receipt#47022
Assignees
techievivekjoekaufmanexpensifyshubham1206agradominictb
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@m-natarajan
m-natarajan
opened on Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #42302
Version Number: 9.0.18.0
Reproducible in staging?: Yes
Reproducible in production?: New Feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+0708pm1e@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

  1. Open the app and log in
  2. Navigate to a group chat
  3. Tap + > Split expense > Distance
  4. Enter the start and finish viewpoints and complete creating a split expense
  5. Open the receipt

Expected Result:

The receipt is displayed

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565083_1723073513605.IMG_8914.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bdf11a6c8415e801
  • Upwork Job ID: 1821474729087191120
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • shubham1206agra | Reviewer | 103446274
    • dominictb | Contributor | 103446277
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. m-natarajan
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 8, 2024
  2. melvin-bot
    assigned
    techievivek
    on Aug 8, 2024

  3. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    joekaufmanexpensify
    on Aug 8, 2024

  5. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Aug 8, 2024

  7. github-actions commented on Aug 8, 2024

    @github-actions
    github-actionsBot
    on Aug 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. dominictb commented on Aug 8, 2024

    @dominictb
    dominictb
    on Aug 8, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The app crashes

    What is the root cause of that problem?

    Let's see the optimistic receipt data here, the source is a static image and for IOS native the type of this source is a number.

    App/src/libs/actions/IOU.ts

    Line 3869 in 53eee53

    const receipt: Receipt | undefined = iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE ? {source: ReceiptGeneric as ReceiptSource, state: CONST.IOU.RECEIPT_STATE.OPEN} : undefined;

    It leads to the optimistic filename is a number,

    App/src/libs/TransactionUtils/index.ts

    Line 166 in 53eee53

    filename: receipt?.source ?? receipt?.name ?? filename,

    Then the app crashes when we use the check Str.isPDF(receiptFilename) here because in this function we have a logic url.split('.')

    What changes do you think we should make in order to solve the problem?

    We should cast the receiptFilename to string when we use the Str.isPDF here

    Str.isPDF(String(receiptFilename))

    App/src/components/MoneyRequestConfirmationListFooter.tsx

    Line 533 in 53eee53

    {isLocalFile && Str.isPDF(receiptFilename) ? (

    What alternative solutions did you explore? (Optional)

    We can cast the filename to String here

    filename: String(receipt?.source ?? receipt?.name ?? filename),

    App/src/libs/TransactionUtils/index.ts

    Line 166 in 53eee53

    filename: receipt?.source ?? receipt?.name ?? filename,

  9. techievivek
    assigned
    shubham1206agra
    on Aug 8, 2024
  10. techievivek
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 8, 2024

  11. 30 remaining items

  12. joekaufmanexpensify commented on Aug 16, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 16, 2024
    Contributor

    Checklist complete. All set to issue payment on Monday. We need to pay:

  13. shubham1206agra commented on Aug 16, 2024

    @shubham1206agra
    shubham1206agra
    on Aug 16, 2024
    Contributor

    @joekaufmanexpensify I was not the C+ on previous issue 😄

    It was @mananjadhav

  14. joekaufmanexpensify commented on Aug 16, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 16, 2024
    Contributor

    Ah, okay. I saw you listed in the assignees of the PR, but see now that was just as a commenter. Adjusted checklist!

  15. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Aug 18, 2024

  16. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    All set to issue payment here!

  17. melvin-bot
    removed
    Overdue
    on Aug 19, 2024

  18. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    @shubham1206agra could you please accept the offer so we can pay you?

  19. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    @dominictb $250 sent and contract ended!

  20. shubham1206agra commented on Aug 19, 2024

    @shubham1206agra
    shubham1206agra
    on Aug 19, 2024
    Contributor

    @joekaufmanexpensify Offer accepted

  21. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    @shubham1206agra $250 sent and contract ended!

  22. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    Upwork job closed.

  23. joekaufmanexpensify commented on Aug 19, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Aug 19, 2024
    Contributor

    All set, thanks everyone!

  24. joekaufmanexpensify
    closed this as completedon Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions