Skip to content

[HOLD for payment 2024-08-19] [$250] Track expense - App throws error when submitting track distance expense #47042

New issue
New issue
Closed
Closed
[HOLD for payment 2024-08-19] [$250] Track expense - App throws error when submitting track distance expense#47042
Assignees
pecanorojjcoffeestephanieelliottdominictb
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Click + > Track expense > Distance.
  4. Submit a track distance expense.

Expected Result:

The track distance expense will be created successfully.

Actual Result:

App throws error when submitting track distance expense - There is a previously existing chat between these users.

Workaround:

Uncnown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565175_1723084027231.20240808_102342.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018888d22189418e67
  • Upwork Job ID: 1821495281651751011
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • jjcoffee | Reviewer | 103448882
    • dominictb | Contributor | 103448883
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 8, 2024
  2. melvin-bot
    assigned
    stephanieelliott
    on Aug 8, 2024

  3. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    pecanoro
    on Aug 8, 2024

  5. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Aug 8, 2024

  7. github-actions commented on Aug 8, 2024

    @github-actions
    github-actionsBot
    on Aug 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. IuliiaHerets commented on Aug 8, 2024

    @IuliiaHerets
    IuliiaHerets
    on Aug 8, 2024
    Author

    We think that this bug might be related to #vip-vsb

  9. pecanoro commented on Aug 8, 2024

    @pecanoro
    pecanoro
    on Aug 8, 2024
    Contributor

    I can reproduce but if it's not coming from the back-end, I am wondering if we changed the API request in some PR, looking!

    image

  10. pecanoro commented on Aug 8, 2024

    @pecanoro
    pecanoro
    on Aug 8, 2024
    Contributor

    Oh, on production we call TrackExpense and we call CreateDistanceRequest on staging

    image

    image

  11. 30 remaining items

  12. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Aug 12, 2024
  13. melvin-bot
    changed the title [-][$250] Track expense - App throws error when submitting track distance expense[/-] [+][HOLD for payment 2024-08-19] [$250] Track expense - App throws error when submitting track distance expense[/+] on Aug 12, 2024

  14. melvin-bot commented on Aug 12, 2024

    @melvin-bot
    melvin-botBot
    on Aug 12, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Aug 12, 2024

  16. melvin-bot commented on Aug 12, 2024

    @melvin-bot
    melvin-botBot
    on Aug 12, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-19. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Aug 12, 2024

    @melvin-bot
    melvin-botBot
    on Aug 12, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
    • [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jjcoffee] Determine if we should create a regression test for this bug.
    • [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Aug 18, 2024

  19. stephanieelliott commented on Aug 20, 2024

    @stephanieelliott
    stephanieelliott
    on Aug 20, 2024
    Contributor

    Summarizing payment on this issue:

    • Contributor: @dominictb $250 via Upwork - PAID
    • Contributor+: @jjcoffee $250 via Upwork - PAID

    Upwork job is here: https://www.upwork.com/jobs/~018888d22189418e67

  20. melvin-bot
    removed
    Overdue
    on Aug 20, 2024

  21. stephanieelliott commented on Aug 20, 2024

    @stephanieelliott
    stephanieelliott
    on Aug 20, 2024
    Contributor

    Hey @jjcoffee can you please complete the BZ checklist for this when you get a sec?

  22. jjcoffee commented on Aug 20, 2024

    @jjcoffee
    jjcoffee
    on Aug 20, 2024
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Enable distance splits #42302
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42302/files#r1723447110
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - should've been caught in checklist
    • Determine if we should create a regression test for this bug. Yes - although one most likely already exists
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to self DM.
    2. Click + > Track expense > Distance.
    3. Submit a track distance expense.
    4. Verify that the expense shows up with no errors.

    Do we agree 👍 or 👎

  23. stephanieelliott commented on Aug 21, 2024

    @stephanieelliott
    stephanieelliott
    on Aug 21, 2024
    Contributor

    Test case created! https://github.com/Expensify/Expensify/issues/422130

    All done here, thanks!

  24. stephanieelliott
    closed this as completedon Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions