[HOLD for payment 2024-12-12] [$125] Web - Search - Filters - Extra margin below Save button in Category filter

@isabelastisser

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com

Action Performed:

Go to staging.new.expensify.com/search/filters
Click Category.

Expected Result:

There will be no extra margin below the Save button (production behavior).

Actual Result:

There is extra margin below the Save button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6565196_1723085486947.20240808_104712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012f06d1723cda4320
Upwork Job ID: 1821488943174214137
Last Price Increase: 2024-08-08
Automatic offers:

dominictb | Contributor | 103505005

Issue Owner

Current Issue Owner: @isabelastisser

@cristipaval

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Search - Filters - Extra margin below Save button in Category filter

What is the root cause of that problem?

Extra padding bottom is applied. When we pass footer component them it is wrapped with FixedFooter which already applies the margin for the footerContent.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 138 in 53eee53

What changes do you think we should make in order to solve the problem?

Remove styles.pb5.

We should also remove includeSafeAreaPaddingBottom={false} if needed, the default is true so we can remove that.

App/src/pages/Search/SearchFiltersCategoryPage.tsx

Line 129 in 53eee53

includeSafeAreaPaddingBottom={false}

What alternative solutions did you explore? (Optional)

We can use the confirm button in SelectionList and the we can remove footer content from SearchFiltersCategoryPage.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 726 to 738 in 53eee53

    
           {showConfirmButton && ( 
        
               <FixedFooter style={[styles.mtAuto]}> 
        
                   <Button 
        
                       success 
        
                       large 
        
                       style={[styles.w100]} 
        
                       text={confirmButtonText || translate('common.confirm')} 
        
                       onPress={onConfirm} 
        
                       pressOnEnter 
        
                       enterKeyEventListenerPriority={1} 
        
                   /> 
        
               </FixedFooter> 
        
           )}

We need to pass the following props:

                        showConfirmButton
                        confirmButtonText={translate('common.save')}
                        onConfirm={handleConfirmSelection}

Reviewing label has been removed, please complete the "BugZero Checklist".

@allroundexperts

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix button top margin in SearchMultipleSelectionPicker #53241

If no regressions arise, payment will be issued on 2024-12-12. 🎊

For reference, here are some details about the assignees on this issue:

@allroundexperts requires payment through NewDot Manual Requests
@dominictb requires payment automatic offer (Contributor)

@allroundexperts

@allroundexperts / @dominictb @isabelastisser @allroundexperts / @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@isabelastisser

@isabelastisser Payments haven't been made here, can you help reopen the issue? TIA

@dominictb

Payment summary:

@dominictb: contributor, $125. Paid in Upwork.
@allroundexperts: C+ review, $125. Payment PENDING in NewDot.

@allroundexperts

@allroundexperts, did you already request payment for this issue in ND?

@isabelastisser

@isabelastisser I have noted this one down. Please feel free to close.

Thanks! All set.

@allroundexperts

$125 approved for @allroundexperts

Navigation Menu

Repository navigation

[HOLD for payment 2024-12-12] [$125] Web - Search - Filters - Extra margin below Save button in Category filter #47046

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

57 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{showConfirmButton && (
	<FixedFooter style={[styles.mtAuto]}>
	<Button
	success
	large
	style={[styles.w100]}
	text={confirmButtonText \|\| translate('common.confirm')}
	onPress={onConfirm}
	pressOnEnter
	enterKeyEventListenerPriority={1}
	/>
	</FixedFooter>
	)}

[HOLD for payment 2024-12-12] [$125] Web - Search - Filters - Extra margin below Save button in Category filter #47046

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 8, 2024

melvin-bot commented on Aug 8, 2024

github-actions commented on Aug 8, 2024

IuliiaHerets commented on Aug 8, 2024

Krishna2323 commented on Aug 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

57 remaining items

melvin-bot commented on Dec 5, 2024

melvin-bot commented on Dec 5, 2024

melvin-bot commented on Dec 5, 2024

dominictb commented on Feb 12, 2025

isabelastisser commented on Feb 19, 2025

isabelastisser commented on Feb 19, 2025

allroundexperts commented on Feb 19, 2025

isabelastisser commented on Feb 19, 2025

JmillsExpensify commented on Jun 13, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions