[$250] [P2P Distance] Split - Incorrect amount & distance behavior when changing distance on confirm page offline

@carlosmiceli

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to group chat.
Click + > Split expense > Distance.
Enter waypoints > Next.
On confirmation page, go offline.
Click Distance.
Change distance by swapping position and save it.

Expected Result:

Amount field will be empty.
Distance field will change to Pending.
Split input will be 0.00.

Actual Result:

Amount, Distance and split inputs change to a very big value.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6565228_1723089231018.20240808_114732.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016482e5c32e2edfad
Upwork Job ID: 1823019084308686776
Last Price Increase: 2024-09-02

Issue Owner

Current Issue Owner: @carlosmiceli

@Julesssss

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #vip-split

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The distance, amount, and individual split share changes to a very big value.

What is the root cause of that problem?

From the expected result, the 1st (Amount field will be empty) and 2nd problem (Distance field will change to Pending) is the same root cause as #46952 and is currently being handled in #46964.

For the 3rd problem (Split input will be 0.00), even after we fix the 1st and 2nd, the split amount still won't be 0 when the distance amount is 0 because we only update the individual split amount if the distance amount (amount) is truth (> 0).

App/src/components/MoneyRequestConfirmationList.tsx

Lines 345 to 348 in 9c7c4a1

    
           const participantAccountIDs: number[] = selectedParticipantsProp.map((participant) => participant.accountID ?? -1); 
        
           if (isTypeSplit && !isPolicyExpenseChat && amount && transaction?.currency) { 
        
               IOU.setSplitShares(transaction, amount, currency, participantAccountIDs); 
        
           }

What changes do you think we should make in order to solve the problem?

If we want to update the individual split amount to 0 when the distance amount is 0, then we need to remove the amount check here.

App/src/components/MoneyRequestConfirmationList.tsx

Lines 345 to 348 in 9c7c4a1

    
           const participantAccountIDs: number[] = selectedParticipantsProp.map((participant) => participant.accountID ?? -1); 
        
           if (isTypeSplit && !isPolicyExpenseChat && amount && transaction?.currency) { 
        
               IOU.setSplitShares(transaction, amount, currency, participantAccountIDs); 
        
           }

However, I notice that when we create the split distance while offline with the pending distance, the request will always fail and also, the participant is only the current user because we don't include participants with 0 split amount.

App/src/libs/actions/IOU.ts

Line 4053 in 9c7c4a1

    
           const splits: Split[] = [{email: currentUserEmailForIOUSplit, accountID: currentUserAccountID, amount: currentUserAmount, taxAmount: currentUserTaxAmount}];

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 342 to 352 in 9c7c4a1

    
           let splitParticipants = selectedParticipants; 
        
           // Filter out participants with an amount equal to O 
        
           if (iouType === CONST.IOU.TYPE.SPLIT && transaction?.splitShares) { 
        
               const participantsWithAmount = Object.keys(transaction.splitShares ?? {}) 
        
                   .filter((accountID: string): boolean => (transaction?.splitShares?.[Number(accountID)]?.amount ?? 0) > 0) 
        
                   .map((accountID) => Number(accountID)); 
        
               splitParticipants = selectedParticipants.filter((participant) => 
        
                   participantsWithAmount.includes(participant.isPolicyExpenseChat ? participant?.ownerAccountID ?? -1 : participant.accountID ?? -1), 
        
               ); 
        
           }

App/src/libs/actions/IOU.ts

Lines 4062 to 4066 in 9c7c4a1

    
           // To exclude someone from a split, the amount can be 0. The scenario for this is when creating a split from a group chat, we have remove the option to deselect users to exclude them. 
        
           // We can input '0' next to someone we want to exclude. 
        
           if (splitAmount === 0) { 
        
               return; 
        
           }

I tried to always include the participant even when the amount is 0, but it still fails.

Maybe we can disable the confirmation button if the distance amount is 0.

Not treating this as a blocker. While annoying it should be rare and has an obvious workaround.

@neil-marcellini

@neil-marcellini How do I get location working? I already gave access.

That's odd, might be a separate bug. Try reloading the page, signing out and back in, etc. If you still have trouble you can start looking into the MapView and how it's loaded, how the token is fetched.

I just tried and found out that GetMapboxAccessToken is failing because we removed the token and haven't sent an action required email yet. I explained the solution here.

@carlosmiceli

@carlosmiceli, @greg-schroeder, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

Was OOO, will try to work on it this week after I deal with some backlog.

@carlosmiceli

Okay Thanks @carlosmiceli!

Got carried away with wrapping homepage phase 2 issues, should be able to start this week 🙏

@carlosmiceli

Closing as #vip-split is now closed/archived/paused - let me know if you disagree @carlosmiceli

context: https://expensify.slack.com/archives/C05RECHFBEW/p1727723167802139

Navigation Menu

Repository navigation

[$250] [P2P Distance] Split - Incorrect amount & distance behavior when changing distance on confirm page offline #47048

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

62 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const participantAccountIDs: number[] = selectedParticipantsProp.map((participant) => participant.accountID ?? -1);
	if (isTypeSplit && !isPolicyExpenseChat && amount && transaction?.currency) {
	IOU.setSplitShares(transaction, amount, currency, participantAccountIDs);
	}

	let splitParticipants = selectedParticipants;

	// Filter out participants with an amount equal to O
	if (iouType === CONST.IOU.TYPE.SPLIT && transaction?.splitShares) {
	const participantsWithAmount = Object.keys(transaction.splitShares ?? {})
	.filter((accountID: string): boolean => (transaction?.splitShares?.[Number(accountID)]?.amount ?? 0) > 0)
	.map((accountID) => Number(accountID));
	splitParticipants = selectedParticipants.filter((participant) =>
	participantsWithAmount.includes(participant.isPolicyExpenseChat ? participant?.ownerAccountID ?? -1 : participant.accountID ?? -1),
	);
	}

	// To exclude someone from a split, the amount can be 0. The scenario for this is when creating a split from a group chat, we have remove the option to deselect users to exclude them.
	// We can input '0' next to someone we want to exclude.
	if (splitAmount === 0) {
	return;
	}

[$250] [P2P Distance] Split - Incorrect amount & distance behavior when changing distance on confirm page offline #47048

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 8, 2024

melvin-bot commented on Aug 8, 2024

IuliiaHerets commented on Aug 8, 2024

github-actions commented on Aug 8, 2024

bernhardoj commented on Aug 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Julesssss commented on Aug 8, 2024

62 remaining items

neil-marcellini commented on Sep 19, 2024

melvin-bot commented on Sep 24, 2024

carlosmiceli commented on Sep 25, 2024

greg-schroeder commented on Sep 27, 2024

carlosmiceli commented on Sep 30, 2024

greg-schroeder commented on Oct 1, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions