Skip to content

[$250] Desktop - Unable to log out as user remains logged in after logging out #47088

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify desktop app
  2. Log out if logged in
  3. Log in to New Expensify on Chrome
  4. After login, refresh the page on Chrome
  5. Click Open New Expensify
  6. On desktop app, sign out

Expected Result:

App will redirect to login screen after signing out

Actual Result:

App is unable to sign out. User remains signed in after signing out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6565606_1723121931532.20240808_205625.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01263806ac93543c43
  • Upwork Job ID: 1821608786482827857
  • Last Price Increase: 2024-08-08
Issue OwnerCurrent Issue Owner: @ishpaul777

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Aug 8, 2024
  2. melvin-bot commented on Aug 8, 2024

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Aug 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Aug 8, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. neil-marcellini commented on Aug 8, 2024

    @neil-marcellini
    Contributor

    Looking now

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 8, 2024
  7. melvin-bot commented on Aug 8, 2024

    @melvin-bot
  8. changed the title [-]Desktop - Unable to log out as user remains logged in after logging out[/-] [+][$250] Desktop - Unable to log out as user remains logged in after logging out[/+] on Aug 8, 2024
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 8, 2024
  10. melvin-bot commented on Aug 8, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  11. neil-marcellini commented on Aug 8, 2024

    @neil-marcellini
    Contributor

    After log out there's a call to sign in with the short lived auth token. I'm guessing this has something to do with the transition flow.
    image

  12. neil-marcellini commented on Aug 8, 2024

    @neil-marcellini
    Contributor

    Actually, there's a chance this could be backend so re-applying the label until I learn more.

  13. ishpaul777 commented on Aug 8, 2024

    @ishpaul777
    Contributor

    I am not able to reproduce in Dev Desktop app, Have you been able to reproduce in dev @neil-marcellini ?

  14. neil-marcellini commented on Aug 8, 2024

    @neil-marcellini
    Contributor

    I can't reproduce on dev either 😢. Maybe it's fixed? Hard to say. I'm thinking we'll have to compare the console and network logs to see if we can spot a difference between staging and production, or dev.

  15. ishpaul777 commented on Aug 8, 2024

    @ishpaul777
    Contributor

    This is fixed on staging, by #47099 i guess, @neil-marcellini can you please retest and confirm?

  16. neil-marcellini commented on Aug 8, 2024

    @neil-marcellini
    Contributor

    Ah yep that did it, nice! All done.

    desktop-signout.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DeployBlockerIndicates it should block deploying the APIEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions