[HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account

@kadiealexander

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.18-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Log into an account that have expenses
Click on search, found at the bottom
Select all the expenses, Notice the selected numbers are shown a the top
Log out from the account
Log back in with a different account
Go to search

Expected Result:

Selected number is not show

Actual Result:

Selected number of expenses of the previous account are shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6566633_1723204844051.IMG_3620.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0112a275318e1e1dc4
Upwork Job ID: 1823627646288296373
Last Price Increase: 2024-08-28
Automatic offers:

DylanDylann | Contributor | 103746189

Issue Owner

Current Issue Owner: @kadiealexander

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@kadiealexander

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected expense in search page is persisted through different login.

What is the root cause of that problem?

The number of the selected expenses is coming from the search context provider.

App/src/components/Search/SearchPageHeader.tsx

Line 274 in db669c4

itemsLength={selectedTransactionsKeys.length}

App/src/components/Search/SearchPageHeader.tsx

Line 117 in db669c4

const {selectedTransactions, clearSelectedTransactions} = useSearchContext();

The search context provider is put at App.tsx.

App/src/App.tsx

Line 95 in db669c4

SearchContextProvider,

So, even when the user log out, the context data is still persisted.

What changes do you think we should make in order to solve the problem?

Move the SearchContextProvider to AuthScreen, just like OptionsListContextProvider.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 355 to 356 in db669c4

    
           return ( 
        
               <OptionsListContextProvider>

What alternative solutions did you explore? (Optional)

Call clearSelectedTransactions when AuthScreens is unmounted.

@kadiealexander

@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~0112a275318e1e1dc4

@eVoloshchak

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account #47168 (comment)
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account #47168 (comment)
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account #47168 (comment)
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/428407

@bernhardoj

Payouts due:

Contributor: $250 @bernhardoj via Manual Request
Contributor+: $250 @DylanDylann (offer)

Upwork job is here.

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open Search page
Select some transactions on the page
Logout and relogin
Open Search page again
Verify the selection is cleared and not in a selection mode

Do we agree 👍 or 👎

Payout summary here.

Requested in ND.

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account #47168

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

44 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-09-10][$250] [Search v2.1] Selected expense numbers are shown when logging in to another account #47168

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 9, 2024

lanitochka17 commented on Aug 9, 2024

bernhardoj commented on Aug 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 12, 2024

melvin-bot commented on Aug 14, 2024

melvin-bot commented on Aug 14, 2024

44 remaining items

kadiealexander commented on Sep 12, 2024

kadiealexander commented on Sep 12, 2024

DylanDylann commented on Sep 12, 2024

kadiealexander commented on Sep 16, 2024

bernhardoj commented on Sep 16, 2024

JmillsExpensify commented on Sep 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions