Repository navigation
[HOLD for payment 2024-08-29] [$250] Desktop - Onboarding can be skipped by esc key #47189
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.18-7
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
- Launch New Expensify desktop app.
- Sign up with a new Gmail account.
- During onboarding, press esc key.
Expected Result:
Onboarding cannot be skipped by esc key.
Actual Result:
Onboarding can be skipped by esc key.
This issue only happens on desktop app and not web app.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6566750_1723214372806.20240809_223636.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0115ed02f53aa4456b
- Upwork Job ID: 1822029538491322982
- Last Price Increase: 2024-08-09
- Automatic offers:
- dominictb | Contributor | 103496768
Activity
melvin-bot commentedon Aug 9, 2024
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 9, 2024
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Aug 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jasperhuangg commentedon Aug 9, 2024
Man I almost feel like this should be a feature 😆
No need to block deploy, onboarding isn't necessary to use the App, and it only happens on desktop.
42 remaining items
melvin-bot commentedon Aug 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Krishna2323 commentedon Aug 28, 2024
@allroundexperts, can you please report the other bug in the #expensify-bugs channel and ask the issue creator to assign it to me? I think you should be the C+ there since you have already reviewed this PR and also the solution for the other issue.
jasperhuangg commentedon Aug 30, 2024
Bump @allroundexperts on above 🙇
allroundexperts commentedon Sep 1, 2024
@jasperhuangg Do you think that the bug reported by @Krishna2323 is worth solving? If so, can you create a new issue and assign both of us?
melvin-bot commentedon Sep 2, 2024
@miljakljajic, @allroundexperts, @jasperhuangg, @dominictb Eep! 4 days overdue now. Issues have feelings too...
jasperhuangg commentedon Sep 3, 2024
@Krishna2323 Please report the bug yourself via the #expensify-bugs channel. We'll let it go through our standard process.
Krishna2323 commentedon Sep 3, 2024
Thanks. @allroundexperts, could you please do that for me? I don't have access to #expensify-bugs channel.
miljakljajic commentedon Sep 3, 2024
Payment summary:
@allroundexperts is owed 250 for their work reviewing this PR
miljakljajic commentedon Sep 3, 2024
@dominictb has been paid in upwork
JmillsExpensify commentedon Oct 8, 2024
$250 approved for @allroundexperts