[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline

@shubham1206agra

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a919@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Login with gmail account
Create workspace
Go offline
Go to workspace profile page

Expected Result:

Workspace profile page should not be grayed out since the workspace was created in online mode

Actual Result:

Workspace profile page becomes grayed out when user goes offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6570133_1723480443136.Recording__3695.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182138e49511ea4ac
Upwork Job ID: 1823362392640621309
Last Price Increase: 2024-08-27
Automatic offers:

shubham1206agra | Reviewer | 103705107
Krishna2323 | Contributor | 103705109

Issue Owner

Current Issue Owner: @shubham1206agra

@puneetlath

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@puneetlath

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Workspace profile page becomes grayed out when go offline

What is the root cause of that problem?

Pending fields are not cleared in success data.

App/src/libs/actions/Policy/Policy.ts

Lines 1596 to 1602 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           },

App/src/libs/actions/Policy/Policy.ts

Lines 1673 to 1677 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: null, 
        
               approvalMode: null, 
        
               reimbursementChoice: null, 
        
           },

What changes do you think we should make in order to solve the problem?

Clear pending fields in success data for generalSettings & description also.

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace profile page becomes grayed out when go offline

What is the root cause of that problem?

We add these pendingFields in optimistic data

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

But we do not remove them in Success data

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What changes do you think we should make in order to solve the problem?

Actually, there's no need to include these lines because we're not waiting for a backend response for them. The backend response here doesn’t return a description or general settings, so we can safely remove these two lines.

App/src/libs/actions/Policy/Policy.ts

Lines 1600 to 1601 in 659011e

    
           generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~0182138e49511ea4ac

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

Edited by proposal-police: This proposal was edited at 2024-08-14 11:16:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace profile page becomes grayed out when user goes offline

What is the root cause of that problem?

In this PR, we plan to just add generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION, but description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, is also added.

And these pendingFields are not cleared in successData and failureData:

App/src/libs/actions/Policy/Policy.ts

Lines 1673 to 1677 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: null, 
        
               approvalMode: null, 
        
               reimbursementChoice: null, 
        
           },

leads to the bug.

What changes do you think we should make in order to solve the problem?

We can add:

                    generalSettings: null,
                    description: null,

in:

App/src/libs/actions/Policy/Policy.ts

Line 2254 in 5d57ae8

pendingFields: {

and

        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                pendingAction: null,
                pendingFields: {
                    autoReporting: null,
                    approvalMode: null,
                    reimbursementChoice: null,
                    generalSettings: null,
                    description: null,
                },
            },
        },

in:

App/src/libs/actions/Policy/Policy.ts

Line 2321 in 5d57ae8

const failureData: OnyxUpdate[] = [

After this PR, we will use separately pending field outputCurrency and address instead of using generalSettings. So we need to add these pending to:

App/src/libs/actions/Policy/Policy.ts

Line 1596 in 5d57ae8

pendingFields: {

address: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD

and then also clear these in successData and failureData.

What alternative solutions did you explore? (Optional)

We can remove all the pendingFields:

App/src/libs/actions/Policy/Policy.ts

Lines 1596 to 1602 in 5d57ae8

    
           pendingFields: { 
        
               autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
               description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, 
        
           },

then update:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 199 in 5d57ae8

                            <OfflineWithFeedback pendingAction={policy?.pendingFields?.generalSettings ?? policy?.pendingAction}>

Similar logic should applied to:

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 214 in 5d57ae8

pendingAction={policy?.pendingFields?.description}

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 232 in 5d57ae8

pendingAction={policy?.pendingFields?.generalSettings}

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 252 in 5d57ae8

@Krishna2323

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@trjExpensify

@trjExpensify Can you add label for payment on 12th September?

@puneetlath

@puneetlath has actioned on that, I've added the Awaiting payment label as well now.

@Krishna2323

I've paid @Krishna2323.

@shubham1206agra can you please complete the checklist?

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: fix profile page not greyed out #46130
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/46130/files#r1758104072
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Ok great. All paid. Thanks everyone!

Navigation Menu

Repository navigation

[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline #47260

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pendingFields: {
	autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	generalSettings: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	description: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},

	pendingFields: {
	autoReporting: null,
	approvalMode: null,
	reimbursementChoice: null,
	},

[HOLD for payment 2024-09-12] [$250] Workspace - Workspace profile page becomes grayed out when go offline #47260

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 12, 2024

lanitochka17 commented on Aug 12, 2024

lanitochka17 commented on Aug 12, 2024

Krishna2323 commented on Aug 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nodebrute commented on Aug 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 13, 2024

melvin-bot commented on Aug 13, 2024

dominictb commented on Aug 14, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

melvin-bot commented on Aug 27, 2024

shubham1206agra commented on Sep 7, 2024

trjExpensify commented on Sep 10, 2024

puneetlath commented on Sep 13, 2024

shubham1206agra commented on Sep 13, 2024

puneetlath commented on Sep 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions