[HOLD for payment 2024-10-14] Invoicing payments frontend clean-up

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Project: [#whatsnext] #billpay (view)

Feature Description

The clean-up issue for the workspace invoicing flow. We need to complete all TODOs and uncomment temporary disabled lines.

Manual Test Steps

Automated Tests

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@rezkiy37

@rezkiy37 assigning you to this issue

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@kevinksullivan

@kevinksullivan, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

This issue is on hold until the backend is ready.

@kevinksullivan

@kevinksullivan, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@kevinksullivan

@kevinksullivan, @rezkiy37 Eep! 4 days overdue now. Issues have feelings too...

Reviewing label has been removed, please complete the "BugZero Checklist".

@rezkiy37

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Uncomment invoicing feature lines #49782

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

@rezkiy37 does not require payment (Contractor)

@madmax330

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@madmax330] The PR that introduced the bug has been identified. Link to the PR:
[@madmax330] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@madmax330] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rezkiy37] Determine if we should create a regression test for this bug.
[@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@rezkiy37

[@rezkiy37] Determine if we should create a regression test for this bug.

No, it was not a bug.

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] Invoicing payments frontend clean-up #47302

Part of the Invoicing payments project

Feature Description

Manual Test Steps

Automated Tests

40 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-14] Invoicing payments frontend clean-up #47302

Description

Part of the Invoicing payments project

Feature Description

Manual Test Steps

Automated Tests

Activity

melvin-bot commented on Aug 13, 2024

MonilBhavsar commented on Aug 13, 2024

rezkiy37 commented on Aug 13, 2024

melvin-bot commented on Aug 16, 2024

rezkiy37 commented on Aug 17, 2024

melvin-bot commented on Aug 20, 2024

melvin-bot commented on Aug 22, 2024

40 remaining items

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

rezkiy37 commented on Oct 8, 2024

melvin-bot commented on Oct 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions