Skip to content

[$250] Netsuite - Able to connect Netsuite with incorrect tokens #47493

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4859063&group_by=cases:section_id&group_order=asc&group_id=314239
Email or phone of affected tester (no customers): applausetester+gm1094@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  1. Login with an account that is an admin of a control workspace (or create one in OD if needed)
  2. Enable accounting in workspace settings
    Steps
  3. Navigate to Accounting
  4. Click on the connect button next to NetSuite
  5. Reach the credentials step
  6. Enter incorrect the NetSuite tokens

Expected Result:

When credentials are entered incorrectly a sync error should be displayed

Actual Result:

User is able to connect Netsuite with incorrect tokens. No error message is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6572733_1723709133681.Recording__3717.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f1ac27b5bef67232
  • Upwork Job ID: 1831077669368516851
  • Last Price Increase: 2024-09-03
  • Automatic offers:
    • shubham1206agra | Contributor | 103803673
Issue OwnerCurrent Issue Owner: @rushatgabhane

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 15, 2024
  2. melvin-bot commented on Aug 15, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Aug 15, 2024

    @lanitochka17
    Author

    @sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Aug 15, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-control

  5. sakluger commented on Aug 16, 2024

    @sakluger
    Contributor

    Hey @yuwenmemon, any idea why we're not throwing a connection error here?

  6. self-assigned this
    on Aug 16, 2024
  7. yuwenmemon commented on Aug 16, 2024

    @yuwenmemon
    Contributor

    Weird. Will take a look.

  8. sakluger commented on Aug 19, 2024

    @sakluger
    Contributor

    @yuwenmemon any ideas?

  9. yuwenmemon commented on Aug 21, 2024

    @yuwenmemon
    Contributor

    No update yet, other issues have been taking precedence but will look soon!

  10. 36 remaining items

  11. greg-schroeder commented on Sep 9, 2024

    @greg-schroeder
    Contributor

    Thanks for the update @mananjadhav

  12. mananjadhav commented on Sep 9, 2024

    @mananjadhav
    Collaborator

    SageIntacct adds an error message and a Learn more link which leads to the help.expensify page. For NetSuite should we use this link https://help.expensify.com/articles/expensify-classic/connections/netsuite/Netsuite-Troubleshooting#expensierror-ns0109-failed-to-login-to-netsuite-please-verify-your-credentials ?

  13. yuwenmemon commented on Sep 9, 2024

    @yuwenmemon
    Contributor

    Yeah that would be a nice addition @mananjadhav

  14. melvin-bot commented on Oct 4, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @yuwenmemon, @sakluger, @shubham1206agra eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. sakluger commented on Oct 8, 2024

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @mananjadhav $250, please request on Newdot
    Contributor+: @shubham1206agra $250, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/104323832)

    @shubham1206agra I had to send a new offer - please let me know once you've accepted it. Thanks!

  16. shubham1206agra commented on Oct 8, 2024

    @shubham1206agra
    Contributor

    @sakluger Accepted offer

  17. garrettmknight commented on Oct 8, 2024

    @garrettmknight
    Contributor

    $250 approved for @mananjadhav

  18. sakluger commented on Oct 9, 2024

    @sakluger
    Contributor

    Thanks everyone! I completed payment to @shubham1206agra so we're good to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions