[HOLD for payment 2024-08-26] Workspace switcher - Huge gap between "Create a workspace" modal and "Workspaces" title

@wildan-m

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.21-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

Account has no workspace.

Go to staging.new.expensify.com
Open workspace switcher.

Expected Result:

"Create a workspace" modal should be right below the "Workspaces" title (production behavior).

Actual Result:

There is huge gap between "Create a workspace" modal and "Workspaces" title.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6574871_1723923186190!Screenshot_2024-08-18_at_03 30 12

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @wildan-m

@luacmartins

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #vip-vsb

It might be caused by #47527

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The logic in this render might be incorrect:

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 690 to 695 in 62722e8

    
           {(((!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && !!headerMessage) || 
        
               (flattenedSections.allOptions.length === 0 && !showLoadingPlaceholder)) && ( 
        
               <View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}> 
        
                   <Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>{headerMessage}</Text> 
        
               </View> 
        
           )}

headerMessage value should be mandatory to show the component

What changes do you think we should make in order to solve the problem?

Change the logic to

{(
    ((!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) ||
    (flattenedSections.allOptions.length === 0 && !showLoadingPlaceholder)) &&
    !!headerMessage
) && (
    <View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}>
        <Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>
            {headerMessage}
        </Text>
    </View>
)}

What alternative solutions did you explore? (Optional)

N/A

@wildan-m

@wildan-m are you available to work on a fix?

Reviewing label has been removed, please complete the "BugZero Checklist".

@wildan-m

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix headerMessage wrapper render logic #47634

If no regressions arise, payment will be issued on 2024-08-26. 🎊

For reference, here are some details about the assignees on this issue:

@wildan-m requires payment (Needs manual offer from BZ)

@luacmartins

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@wildan-m] Determine if we should create a regression test for this bug.
[@wildan-m] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

I think we don't need to create regression test, it's not directly related to any flow

Is "Needs manual offer from BZ" a payment method? Can I receive payment through UpWork instead?

@luacmartins

@luacmartins @abekkala bump for payment

@luacmartins

@luacmartins bump #47601 (comment)

@abekkala

Seems like I closed this issue without payment 😬 Reopening so we can process it @abekkala

@wildan-m

PAYMENT SUMMARY

Fix @wildan-m [$250] OFFER
PR Review: internal @luacmartins

@abekkala

@abekkala thanks, accepted the offer

@wildan-m

@wildan-m payment sent and contract ended - thank you! 🎉

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-26] Workspace switcher - Huge gap between "Create a workspace" modal and "Workspaces" title #47601

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

21 remaining items

PAYMENT SUMMARY

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{(((!isLoadingNewOptions \|\| headerMessage !== translate('common.noResultsFound')) && !!headerMessage) \|\|
	(flattenedSections.allOptions.length === 0 && !showLoadingPlaceholder)) && (
	<View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}>
	<Text style={[styles.textLabel, styles.colorMuted, styles.minHeight5]}>{headerMessage}</Text>
	</View>
	)}

[HOLD for payment 2024-08-26] Workspace switcher - Huge gap between "Create a workspace" modal and "Workspaces" title #47601

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 17, 2024

melvin-bot commented on Aug 17, 2024

github-actions commented on Aug 17, 2024

IuliiaHerets commented on Aug 17, 2024

etCoderDysto commented on Aug 17, 2024

wildan-m commented on Aug 18, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

luacmartins commented on Aug 19, 2024

21 remaining items

melvin-bot commented on Aug 19, 2024

melvin-bot commented on Aug 19, 2024

melvin-bot commented on Aug 19, 2024

wildan-m commented on Aug 27, 2024

wildan-m commented on Sep 3, 2024

wildan-m commented on Sep 6, 2024

luacmartins commented on Sep 6, 2024

abekkala commented on Sep 6, 2024

PAYMENT SUMMARY

wildan-m commented on Sep 6, 2024

abekkala commented on Sep 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions