You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background #47662
Version Number: 9.0.22-5 Reproducible in staging?: Y Reproducible in production?: N
Issue was found when executing this PR: #46760 Issue reported by: Applause Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-][+][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+]on Aug 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-][+][HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+]on Aug 23, 2024
Activity
melvin-bot commentedon Aug 19, 2024
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 19, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Aug 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Aug 19, 2024
We think that this bug might be related to #vip-vsb
neil-marcellini commentedon Aug 19, 2024
I'm quite suspicious of this PR #47096
18 remaining items
neil-marcellini commentedon Aug 20, 2024
@abekkala would you please pay @situchan for raising/testing the revert PR and then we can close this out?
abekkala commentedon Aug 21, 2024
@neil-marcellini would this one still need to wait the 7 days before payment?
neil-marcellini commentedon Aug 21, 2024
No
abekkala commentedon Aug 22, 2024
@situchan Offer Sent!
PAYMENT SUMMARY
[-][$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-][+][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+]melvin-bot commentedon Aug 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
KeyboardAvoidingViewfromreact-native-keyboard-controller" #47669If no regressions arise, payment will be issued on 2024-08-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Aug 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
abekkala commentedon Aug 23, 2024
@neil-marcellini commented that 7 day waiting period was not needed for this payment.
abekkala commentedon Aug 23, 2024
waiting for @situchan to accept the offer in Upwork, then I can process payment and end contract
[-][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-][+][HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+]abekkala commentedon Aug 27, 2024
@situchan payment sent and contract ended - thank you! 🎉