Skip to content

[HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background #47662

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.22-5
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #46760
Issue reported by: Applause Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com/r/2091104345528462
    with the native app from an external program
  2. Tap on the "Sign in" button
  3. Tap inside the email field
  4. Enter an existing account and tap on the "Go" button on the keyboard

Expected Result:

I should be able to see the sign in screen.

Actual Result:

Large part of a public rooms sign in screen is overlapped by green background.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6576390_1724094561313.FKCC4005.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f1319e70bc585069
  • Upwork Job ID: 1825626178043130429
  • Last Price Increase: 2024-08-19
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 19, 2024
  2. melvin-bot commented on Aug 19, 2024

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 19, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Aug 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. IuliiaHerets commented on Aug 19, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-vsb

  6. neil-marcellini commented on Aug 19, 2024

    @neil-marcellini
    Contributor

    I'm quite suspicious of this PR #47096

  7. 18 remaining items

  8. neil-marcellini commented on Aug 20, 2024

    @neil-marcellini
    Contributor

    @abekkala would you please pay @situchan for raising/testing the revert PR and then we can close this out?

  9. abekkala commented on Aug 21, 2024

    @abekkala
    Contributor

    @neil-marcellini would this one still need to wait the 7 days before payment?

  10. neil-marcellini commented on Aug 21, 2024

    @neil-marcellini
    Contributor

    No

  11. abekkala commented on Aug 22, 2024

    @abekkala
    Contributor

    @situchan Offer Sent!

    PAYMENT SUMMARY

    • Raising and testing the revert PR: @situchan [$250]
    • PR Review: Internal
  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 22, 2024
  13. changed the title [-][$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-] [+][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+] on Aug 22, 2024
  14. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-29. 🎊

    For reference, here are some details about the assignees on this issue:

    • @situchan requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. abekkala commented on Aug 23, 2024

    @abekkala
    Contributor

    @neil-marcellini commented that 7 day waiting period was not needed for this payment.

  17. abekkala commented on Aug 23, 2024

    @abekkala
    Contributor

    waiting for @situchan to accept the offer in Upwork, then I can process payment and end contract

  18. changed the title [-][HOLD for payment 2024-08-29] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/-] [+][HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background[/+] on Aug 23, 2024
  19. abekkala commented on Aug 27, 2024

    @abekkala
    Contributor

    @situchan payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions