Search - App exits selection mode when going to a different status #47672
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.22-5
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- Account has expenses in Outstanding or Paid tabs.
- Launch New Expensify app.
- Go to Search.
- Long press on the expense > Select.
- Go to a different status (outstanding for example).
Expected Result:
Describe what you think should've happened
Actual Result:
App exits selection mode when going to a different status.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Aug 19, 2024
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 19, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Aug 19, 2024
We think that this bug might be related to #wave-collect - Release 1
github-actions commentedon Aug 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
rayane-d commentedon Aug 19, 2024
I think this is expected and not a bug
cc @luacmartins
francoisl commentedon Aug 19, 2024
Yeah I could see it being on purpose, otherwise it might be confusing if, for example, you switch between expense statuses, select other expenses, then you tap on the "[N] selected" > "Download" option, and have a bunch of expenses from the previous view included in the download.
francoisl commentedon Aug 19, 2024
Either way, doesn't sound like something worth blocking for. Going to demote until confirmation.
daledah commentedon Aug 20, 2024
Edited by proposal-police: This proposal was edited at 2024-08-20 06:13:22 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App exits selection mode when going to a different status.
What is the root cause of that problem?
When changing the status, we will clear the selected transactions, so we won't face with @francoisl's issue
And we have the logic to turn off selection mode in
App/src/components/SelectionListWithModal/index.tsx
Line 65 in 80236f5
That means when status change, we also disable selection mode.
If we want to keep the selection mode:
we should remove this line:
App/src/components/SelectionListWithModal/index.tsx
Line 65 in 80236f5
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
Kicu commentedon Aug 20, 2024
I agree with @rayane-djouah that IMO this is not a bug.
To expand: every time we change
statusortype(status is coming from status bar, type is coming from the pop-up selector, onlyExpensefor now) we are changing the current Search Query.Every time part of query changes we need to make a fresh request to backend and might get completely different list of results. And we will get a full re-render of displayed results because of that.
I think trying to preserve selection mode between this search re-renders will be more confusing in the long run.
Also this is a related issue: #47670 where the same thing applies to the part: "selection is cleared when going from Inbox to Search" - in that case I believe dropping the selection also makes sense.
CC @luacmartins
luacmartins commentedon Aug 20, 2024
This is not a bug. Closing.