Skip to content

[HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15 #47679

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.22-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4873332
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to conversation with existing history
  3. Tap on Compose box to open keyboard
  4. Hold a message and copy it

Expected Result:

Message should be copied and composer should be visible above keyboard

Actual Result:

Message is copied but composer is hidden behind keyboard. The keyboard can't be dismissed by swiping down.
Issue is only reproducible with older devices. Reproduced with iPhone 7/iOS 15.8.2 and iPhone 8/iOS 15.7.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6576519_1724103523927.CUWH4560.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Aug 20, 2024
  2. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 20, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Aug 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. IuliiaHerets commented on Aug 20, 2024

    @IuliiaHerets
    Author

    Production - not reproduced

    ESHM8018.MP4
  6. IuliiaHerets commented on Aug 20, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-vsb

  7. techievivek commented on Aug 20, 2024

    @techievivek
    Contributor

    Seems like this is coming from here #47096

  8. techievivek commented on Aug 20, 2024

    @techievivek
    Contributor

    I already see a revert PR here #47669 but there is no progress on the PR so I have bumped the author to see what is holding us from moving forward.

  9. removed
    DeployBlockerIndicates it should block deploying the API
    on Aug 20, 2024
  10. neil-marcellini commented on Aug 20, 2024

    @neil-marcellini
    Contributor

    @IuliiaHerets @techievivek the revert is done, would you please test on staging and confirm it's fixed?

  11. m-natarajan commented on Aug 20, 2024

    @m-natarajan

    Issue is not reproducible on build v9. 0. 22-7

    SSHK1579.MP4
  12. techievivek commented on Aug 20, 2024

    @techievivek
    Contributor

    Going to close this now. Thanks for confirming.

  13. changed the title [-]iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/-] [+][HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/+] on Aug 22, 2024
  14. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-29. 🎊

  15. melvin-bot commented on Aug 22, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@techievivek] The PR that introduced the bug has been identified. Link to the PR:
    • [@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@techievivek] Determine if we should create a regression test for this bug.
    • [@techievivek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions