You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15 #47679
Version Number: v9.0.22-5 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4873332 Issue reported by: Applause Internal Team
Action Performed:
Launch New Expensify app
Go to conversation with existing history
Tap on Compose box to open keyboard
Hold a message and copy it
Expected Result:
Message should be copied and composer should be visible above keyboard
Actual Result:
Message is copied but composer is hidden behind keyboard. The keyboard can't be dismissed by swiping down.
Issue is only reproducible with older devices. Reproduced with iPhone 7/iOS 15.8.2 and iPhone 8/iOS 15.7.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/-][+][HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/+]on Aug 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@techievivek] The PR that introduced the bug has been identified. Link to the PR:
[@techievivek] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@techievivek] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@techievivek] Determine if we should create a regression test for this bug.
[@techievivek] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Aug 20, 2024
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Aug 20, 2024
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Aug 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Aug 20, 2024
Production - not reproduced
ESHM8018.MP4
IuliiaHerets commentedon Aug 20, 2024
We think that this bug might be related to #vip-vsb
techievivek commentedon Aug 20, 2024
Seems like this is coming from here #47096
techievivek commentedon Aug 20, 2024
I already see a revert PR here #47669 but there is no progress on the PR so I have bumped the author to see what is holding us from moving forward.
neil-marcellini commentedon Aug 20, 2024
@IuliiaHerets @techievivek the revert is done, would you please test on staging and confirm it's fixed?
m-natarajan commentedon Aug 20, 2024
Issue is not reproducible on build v9. 0. 22-7
SSHK1579.MP4
techievivek commentedon Aug 20, 2024
Going to close this now. Thanks for confirming.
fix: properly report height for `didShow` event happening during anim…
[-]iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/-][+][HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15[/+]melvin-bot commentedon Aug 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
KeyboardAvoidingViewfromreact-native-keyboard-controller" #47669If no regressions arise, payment will be issued on 2024-08-29. 🎊
melvin-bot commentedon Aug 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: