Skip to content

[HOLD for payment 2024-08-29] [$250] Error while task creation via QAB when assigning task to yourself #47680

New issue
New issue
Closed
Closed
[HOLD for payment 2024-08-29] [$250] Error while task creation via QAB when assigning task to yourself#47680
Assignees
techievivekVictoriaExpensifyallgandalfnkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Aug 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.22-5
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47138
Email or phone of affected tester (no customers): applausetester+ck57@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a new workspace
  3. Go to the Admins room
  4. Tap + icon in composer >> select Assign task >> Enter task title/description
  5. Assignee the task to yourself (assign to me option)
  6. Tap green FAB button
  7. Click on the Quick Action button and complete the task assignment flow.

Expected Result:

Task should be successfully created via QAB when assign task to yourself

Actual Result:

Error when assigning task to yourself via QAB.
"Hidden" is displayed instead of user's email for already created tasks

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6576715_1724126159179.Recording__142.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015871a3b0adb66304
  • Upwork Job ID: 1825794705774448587
  • Last Price Increase: 2024-08-20
  • Automatic offers:
    • allgandalf | Reviewer | 103599149
    • nkdengineer | Contributor | 103599150
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 20, 2024
  2. melvin-bot
    assigned
    techievivek
    and
    VictoriaExpensify
    on Aug 20, 2024

  3. melvin-bot commented on Aug 20, 2024

    @melvin-bot
    melvin-botBot
    on Aug 20, 2024 – with Melvin Bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Aug 20, 2024

    @melvin-bot
    melvin-botBot
    on Aug 20, 2024 – with Melvin Bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot
    added
    DailyKSv2
    on Aug 20, 2024
  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Aug 20, 2024

  7. github-actions commented on Aug 20, 2024

    @github-actions
    github-actionsBot
    on Aug 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. IuliiaHerets commented on Aug 20, 2024

    @IuliiaHerets
    IuliiaHerets
    on Aug 20, 2024
    Author

    We think that this bug might be related to #vip-vsb

  9. nkdengineer commented on Aug 20, 2024

    @nkdengineer
    nkdengineer
    on Aug 20, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Error when assigning task to yourself via QAB.
    "Hidden" is displayed instead of user's email for already created tasks

    What is the root cause of that problem?

    We always pass isCurrentUser param as false here

    App/src/libs/actions/Task.ts

    Line 837 in 80236f5

    setAssigneeValue(accountLogin, accountID, reportID, chatReport, false, skipConfirmation);

    then because the chat report is undefined, an optimistic chat report is generated for the current user then assigneeChatReportID in the param of CreateTask API become invalid reportID which causes the error

    App/src/libs/actions/Task.ts

    Line 796 in 80236f5

    setAssigneeChatReport({

    What changes do you think we should make in order to solve the problem?

    We should pass isCurrentUser as accountID === currentUserAccountID or I think we can remove isCurrentUser and use assigneeAccountID to check the assignee is the current user or not

    setAssigneeValue(accountLogin, accountID, reportID, chatReport, accountID === currentUserAccountID, skipConfirmation);

    App/src/libs/actions/Task.ts

    Line 837 in 80236f5

    setAssigneeValue(accountLogin, accountID, reportID, chatReport, false, skipConfirmation);

    What alternative solutions did you explore? (Optional)

    NA

  10. techievivek commented on Aug 20, 2024

    @techievivek
    techievivek
    on Aug 20, 2024
    Contributor

    Hmm, I am unable to figure out any recent change that could have caused this but this is not reproducible on prod. 😕

  11. techievivek commented on Aug 20, 2024

    @techievivek
    techievivek
    on Aug 20, 2024
    Contributor

    Going to bring in a C+ to help us move this forward.

  12. 21 remaining items

  13. allgandalf commented on Aug 21, 2024

    @allgandalf
    allgandalf
    on Aug 21, 2024
    Contributor

    Automation failed, this PR made to production yesterday

  14. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Aug 22, 2024
  15. melvin-bot
    changed the title [-][$250] Error while task creation via QAB when assigning task to yourself[/-] [+][HOLD for payment 2024-08-29] [$250] Error while task creation via QAB when assigning task to yourself[/+] on Aug 22, 2024

  16. melvin-bot commented on Aug 22, 2024

    @melvin-bot
    melvin-botBot
    on Aug 22, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot
    removed
    ReviewingHas a PR in review
    on Aug 22, 2024

  18. melvin-bot commented on Aug 22, 2024

    @melvin-bot
    melvin-botBot
    on Aug 22, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-29. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Aug 22, 2024

    @melvin-bot
    melvin-botBot
    on Aug 22, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
    • [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allgandalf] Determine if we should create a regression test for this bug.
    • [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  20. allgandalf commented on Aug 27, 2024

    @allgandalf
    allgandalf
    on Aug 27, 2024
    Contributor

    Regression Test Proposal

    1. Create a new workspace
    2. Go to the Admins room
    3. Tap + icon in composer >> select Assign task >> Enter task title/description
    4. Assignee the task to yourself (assign to me option)
    5. Tap green FAB button
    6. Click on the Quick Action button and complete the task assignment flow.

    Verify that: Task should be successfully created via QAB when assign task to yourself

    Do we agree 👍 or 👎

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 28, 2024

  22. VictoriaExpensify commented on Aug 29, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Aug 29, 2024
    Contributor

    Regression testing looks good @allgandalf, created a GH to add this to TestRail - https://github.com/Expensify/Expensify/issues/424225

  23. VictoriaExpensify commented on Aug 29, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Aug 29, 2024
    Contributor

    Payment Summary:
    Contributor: @nkdengineer paid $250 via Upwork
    Contributor+: @allgandalf paid $250 via Upwork
    Upwork job

    Thanks for your work on this issue!

  24. VictoriaExpensify
    closed this as completedon Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions