[HOLD for payment 2024-10-14] [$250] Sign in–Magic code expired appears briefly if use Request one here link & login via magic link

@greg-schroeder

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4886771
Email or phone of affected tester (no customers): applausetester+jp_322824@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
On the log in screen, enter a new account email
Repeat the previous step with the same email - This is to receive 2 validation links
Navigate to the account email inbox and open the first email of the 2
Copy the magic link and change it to staging
Navigate to the staging link
Verify Magic code expired page opens
Click on Request one here link
Navigate to the account email inbox and open the email
Copy the magic link, change it to staging and navigate to the staging link

Expected Result:

Magic code expired not appears briefly

Actual Result:

Magic code expired appears briefly

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6579619_1724356216934.MC.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015ba582e21228c322
Upwork Job ID: 1828311848767754708
Last Price Increase: 2024-09-10

Issue Owner

Current Issue Owner: @greg-schroeder

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@greg-schroeder

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user sees the ValidateCodeModal instead of a loading screen when accessing the magic link.

What is the root cause of that problem?

Here in ValidateLoginPage:

App/src/pages/ValidateLoginPage/index.website.tsx

Line 77 in 844c6bf

    
           {(!session?.autoAuthState ? !shouldStartSignInWithValidateCode : autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED) && !exitTo && (

This condition returns true even when shouldStartSignInWithValidateCode is true. This caused the ValidateCodeModal to be shown to the user.

What changes do you think we should make in order to solve the problem?

By changing the condition to
!shouldStartSignInWithValidateCode && autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && !exitTo
By this we can prevent the display ValidateCodeModal, and we can display the Loading Indicator instead of the ValidateCodeModal including it in the condition for FullScreenLoadingIndicator.
I suggest making the changes as follows:

    // If session.autoAuthState isn't available yet, we use shouldStartSignInWithValidateCode to conditionally render the component instead of local autoAuthState which contains a default value of NOT_STARTED
    const shouldValidateModal = !shouldStartSignInWithValidateCode && autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && !exitTo;
    const isFailed = autoAuthState === CONST.AUTO_AUTH_STATE.FAILED;
    const isJustSignedIn2FA = autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN && is2FARequired && !isSignedIn && login;
    const isJustSignedIn = autoAuthState === CONST.AUTO_AUTH_STATE.JUST_SIGNED_IN && isSignedIn && !exitTo && login;

    return (
        <>
            {isFailed && <ExpiredValidateCodeModal />}
            {isJustSignedIn2FA && <JustSignedInModal is2FARequired />}
            {isJustSignedIn && <JustSignedInModal is2FARequired={false} />}
            {shouldValidateModal && (
                <ValidateCodeModal
                    accountID={Number(accountID)}
                    code={validateCode}
                />
            )}
            {!shouldValidateModal && !isJustSignedIn && !isJustSignedIn2FA && <FullScreenLoadingIndicator />}
        </>
    );

@greg-schroeder

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Job added to Upwork: https://www.upwork.com/jobs/~015ba582e21228c322

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Requested in ND.

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Error modal when signin from expired magic link #15505
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Error modal when signin from expired magic link #15505 (comment)
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Log out from the app
Enter your login once
Go back
Enter your login again. Verify you receive 2 magic code & link emails
Open the first email magic link
Verify a magic code expired is shown
Open the second email magic link
Verify a magic code expired isn't shown briefly

Do you agree 👍 or 👎 ?

Oops - regression period is actually 10/14 because the 10/11 date is for the Onyx bump PR, not the PR that fixes this. Updated

@parasharrajat

Payment Summary

Upwork Job

Reviewer: @parasharrajat owed $250 via NewDot
Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1828311848767754708/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

All right, these manual requests can be approved per #47883 (comment)

Adding regression test, closing!

@bernhardoj

$250 approved for @bernhardoj

Payment requested as per #47883 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] [$250] Sign in–Magic code expired appears briefly if use Request one here link & login via magic link #47883

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

57 remaining items

Regression Test Steps

Payment Summary

BugZero Checklist (@greg-schroeder)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-14] [$250] Sign in–Magic code expired appears briefly if use Request one here link & login via magic link #47883

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 22, 2024

IuliiaHerets commented on Aug 22, 2024

Amoralchik commented on Aug 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Aug 26, 2024

melvin-bot commented on Aug 27, 2024

melvin-bot commented on Aug 27, 2024

57 remaining items

bernhardoj commented on Oct 9, 2024

parasharrajat commented on Oct 9, 2024

Regression Test Steps

greg-schroeder commented on Oct 11, 2024

melvin-bot commented on Oct 14, 2024

Payment Summary

BugZero Checklist (@greg-schroeder)

greg-schroeder commented on Oct 14, 2024

greg-schroeder commented on Oct 14, 2024

JmillsExpensify commented on Oct 15, 2024

parasharrajat commented on Dec 12, 2024

JmillsExpensify commented on Dec 16, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions